<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19903">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CTRL funcs: on rate counter mismatch, show all mismatches<br><br>When rate counters have unexpected counts, show all mismatches instead of just<br>the first mismatch. That saves many iterations when fixing rate counter<br>expectations.<br><br>Change-Id: I70b319adcecc3ff7a85a0206b8dc2285133943c1<br>---<br>M library/Osmocom_CTRL_Functions.ttcn<br>1 file changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/19903/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/Osmocom_CTRL_Functions.ttcn b/library/Osmocom_CTRL_Functions.ttcn</span><br><span>index d26dc89..73fd05b 100644</span><br><span>--- a/library/Osmocom_CTRL_Functions.ttcn</span><br><span>+++ b/library/Osmocom_CTRL_Functions.ttcn</span><br><span>@@ -249,16 +249,23 @@</span><br><span>   function f_counter_name_vals_expect(IPA_CTRL_PT pt, charstring instance_name, integer instance_nr,</span><br><span>                                       CounterNameVals vals) {</span><br><span>          var CounterNameVals now := f_counter_name_vals_get(pt, instance_name, instance_nr, vals);</span><br><span style="color: hsl(120, 100%, 40%);">+             var boolean all_match := true;</span><br><span>               for (var integer i := 0; i < lengthof(vals); i := i + 1) {</span><br><span>                        if (now[i].name != vals[i].name) {</span><br><span>                           setverdict(fail, "Internal error");</span><br><span>                        }</span><br><span>                    if (now[i].val != vals[i].val) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                setverdict(fail, "Rate counter mismatch: ", instance_name, " ", instance_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+                              all_match := false;</span><br><span style="color: hsl(120, 100%, 40%);">+                           log("Rate counter mismatch: ", instance_name, " ", instance_nr,</span><br><span>                                     " ", vals[i].name, " is at ", now[i].val, " but expected ", vals[i].val);</span><br><span>                   }</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-               setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+           if (all_match) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+             } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      setverdict(fail, "Rate counter mismatch, see log");</span><br><span style="color: hsl(120, 100%, 40%);">+         }</span><br><span>    }</span><br><span> </span><br><span>        /* For N instances, call f_counter_name_vals_get() and compare with expected counter values.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19903">change 19903</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19903"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I70b319adcecc3ff7a85a0206b8dc2285133943c1 </div>
<div style="display:none"> Gerrit-Change-Number: 19903 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>