<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19898">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add {BTS,BSC}_CTR_INTER_BSC_HO_OUT_FAILED for RR HO Failure<br><br>So far, during inter-BSC outgoing handover, when receiving an RR Handover<br>Failure from the MS, it would be counted as 'error'. Instead, add the 'failed'<br>counter like for all other HO types.<br><br>It may make sense to omit the 'failed' counter for inter-BSC *incoming*<br>handover, because then we won't receive an RR Handover Failure message. I<br>probably got those two mixed up during initial development.<br><br>Related: OS#4736<br>Change-Id: I9a61d5cc7273a830ba4e66e43e4aac6cdb707471<br>---<br>M include/osmocom/bsc/bts.h<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/handover_fsm.c<br>3 files changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/98/19898/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h</span><br><span>index dc51d17..5506a86 100644</span><br><span>--- a/include/osmocom/bsc/bts.h</span><br><span>+++ b/include/osmocom/bsc/bts.h</span><br><span>@@ -93,6 +93,7 @@</span><br><span> BTS_CTR_INTER_BSC_HO_OUT_COMPLETED,</span><br><span> BTS_CTR_INTER_BSC_HO_OUT_STOPPED,</span><br><span> BTS_CTR_INTER_BSC_HO_OUT_TIMEOUT,</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS_CTR_INTER_BSC_HO_OUT_FAILED,</span><br><span> BTS_CTR_INTER_BSC_HO_OUT_ERROR,</span><br><span> BTS_CTR_INTER_BSC_HO_IN_ATTEMPTED,</span><br><span> BTS_CTR_INTER_BSC_HO_IN_COMPLETED,</span><br><span>@@ -190,6 +191,7 @@</span><br><span> "Handover to remote BSS completed"},</span><br><span> [BTS_CTR_INTER_BSC_HO_OUT_STOPPED] = {"interbsc_ho_out:stopped", "Connection ended during HO"},</span><br><span> [BTS_CTR_INTER_BSC_HO_OUT_TIMEOUT] = {"interbsc_ho_out:timeout", "Handover timed out"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BTS_CTR_INTER_BSC_HO_OUT_FAILED] = {"interbsc_ho_out:failed", "Received Handover Fail message"},</span><br><span> [BTS_CTR_INTER_BSC_HO_OUT_ERROR] = {"interbsc_ho_out:error",</span><br><span> "Handover to remote BSS failed for other reason"},</span><br><span> </span><br><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 120c4a4..09c0214 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -987,6 +987,7 @@</span><br><span> BSC_CTR_INTER_BSC_HO_OUT_COMPLETED,</span><br><span> BSC_CTR_INTER_BSC_HO_OUT_STOPPED,</span><br><span> BSC_CTR_INTER_BSC_HO_OUT_TIMEOUT,</span><br><span style="color: hsl(120, 100%, 40%);">+ BSC_CTR_INTER_BSC_HO_OUT_FAILED,</span><br><span> BSC_CTR_INTER_BSC_HO_OUT_ERROR,</span><br><span> BSC_CTR_INTER_BSC_HO_IN_ATTEMPTED,</span><br><span> BSC_CTR_INTER_BSC_HO_IN_COMPLETED,</span><br><span>@@ -1044,6 +1045,7 @@</span><br><span> "Handover to remote BSS completed"},</span><br><span> [BSC_CTR_INTER_BSC_HO_OUT_STOPPED] = {"interbsc_ho_out:stopped", "Connection ended during HO"},</span><br><span> [BSC_CTR_INTER_BSC_HO_OUT_TIMEOUT] = {"interbsc_ho_out:timeout", "Handover timed out"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_INTER_BSC_HO_OUT_FAILED] = {"interbsc_ho_out:failed", "Received Handover Fail message"},</span><br><span> [BSC_CTR_INTER_BSC_HO_OUT_ERROR] = {"interbsc_ho_out:error",</span><br><span> "Handover to remote BSS failed for other reason"},</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index 957d4fa..834b8b4 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -716,6 +716,8 @@</span><br><span> switch (result) {</span><br><span> case HO_RESULT_OK:</span><br><span> return BSC_CTR_INTER_BSC_HO_OUT_COMPLETED;</span><br><span style="color: hsl(120, 100%, 40%);">+ case HO_RESULT_FAIL_RR_HO_FAIL:</span><br><span style="color: hsl(120, 100%, 40%);">+ return BSC_CTR_INTER_BSC_HO_OUT_FAILED;</span><br><span> case HO_RESULT_FAIL_TIMEOUT:</span><br><span> return BSC_CTR_INTER_BSC_HO_OUT_TIMEOUT;</span><br><span> case HO_RESULT_CONN_RELEASE:</span><br><span>@@ -751,6 +753,8 @@</span><br><span> switch (result) {</span><br><span> case HO_RESULT_OK:</span><br><span> return BTS_CTR_INTER_BSC_HO_OUT_COMPLETED;</span><br><span style="color: hsl(120, 100%, 40%);">+ case HO_RESULT_FAIL_RR_HO_FAIL:</span><br><span style="color: hsl(120, 100%, 40%);">+ return BTS_CTR_INTER_BSC_HO_OUT_FAILED;</span><br><span> case HO_RESULT_FAIL_TIMEOUT:</span><br><span> return BTS_CTR_INTER_BSC_HO_OUT_TIMEOUT;</span><br><span> case HO_RESULT_CONN_RELEASE:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19898">change 19898</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19898"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9a61d5cc7273a830ba4e66e43e4aac6cdb707471 </div>
<div style="display:none"> Gerrit-Change-Number: 19898 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>