<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19878">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: log and return warning if adding ss7 host to set fails<br><br>Change-Id: Ib86ef3c3db6096a1e38690b9e598a58387e6b38e<br>---<br>M src/osmo_ss7_vty.c<br>1 file changed, 8 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/78/19878/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c</span><br><span>index 9c31c00..686105e 100644</span><br><span>--- a/src/osmo_ss7_vty.c</span><br><span>+++ b/src/osmo_ss7_vty.c</span><br><span>@@ -628,7 +628,10 @@</span><br><span>        "Local IP Address from which to contact of ASP\n")</span><br><span> {</span><br><span>    struct osmo_ss7_asp *asp = vty->index;</span><br><span style="color: hsl(0, 100%, 40%);">-       osmo_ss7_asp_peer_add_host(&asp->cfg.local, asp, argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (osmo_ss7_asp_peer_add_host(&asp->cfg.local, asp, argv[0]) != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+          vty_out(vty, "%% Failed adding host '%s' to set%s", argv[0], VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+          return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span>    return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span>@@ -638,7 +641,10 @@</span><br><span>  "Remote IP Address of ASP\n")</span><br><span> {</span><br><span>         struct osmo_ss7_asp *asp = vty->index;</span><br><span style="color: hsl(0, 100%, 40%);">-       osmo_ss7_asp_peer_add_host(&asp->cfg.remote, asp, argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+    if (osmo_ss7_asp_peer_add_host(&asp->cfg.remote, asp, argv[0]) != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+         vty_out(vty, "%% Failed adding host '%s' to set%s", argv[0], VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+          return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span>    return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19878">change 19878</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19878"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib86ef3c3db6096a1e38690b9e598a58387e6b38e </div>
<div style="display:none"> Gerrit-Change-Number: 19878 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>