<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19854">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Test Downlink UNIT_DATA messages from SGSN containing IMSI IE<br><br>osmo-pcu.git 0052051c07af63da98137c9f8e3b3119642eb587 introduced a bug<br>(fixed in 1d68cdff928f32941aff36c70e4543203c283d15) where no MS could<br>GMM attach to the network, but no test showed the issue.<br>This couple test verifies both correct behavior and also ensures wrong<br>IMSI is detected and reported.<br><br>Related: OS#4729<br>Change-Id: I5072d80b7ed9945a6083cdf3254efb8b8f119c54<br>---<br>M library/Osmocom_Gb_Types.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 116 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/19854/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn</span><br><span>index a518268..3aeba8f 100644</span><br><span>--- a/library/Osmocom_Gb_Types.ttcn</span><br><span>+++ b/library/Osmocom_Gb_Types.ttcn</span><br><span>@@ -1077,7 +1077,7 @@</span><br><span> template PDU_BSSGP ts_BSSGP_STATUS(template BssgpBvci bvci, template BssgpCause cause,</span><br><span> PDU_BSSGP pdu) := {</span><br><span> pDU_BSSGP_STATUS := {</span><br><span style="color: hsl(0, 100%, 40%);">- bssgpPduType := '0A'O,</span><br><span style="color: hsl(120, 100%, 40%);">+ bssgpPduType := '41'O,</span><br><span> cause := t_BSSGP_CAUSE(cause),</span><br><span> bVCI := t_BSSGP_BVCI(bvci),</span><br><span> pDU_in_Error := {</span><br><span>@@ -1091,6 +1091,23 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ template PDU_BSSGP tr_BSSGP_STATUS(template BVCI bvci := ?, template BssgpCause cause := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ template octetstring pdu := ?) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ pDU_BSSGP_STATUS := {</span><br><span style="color: hsl(120, 100%, 40%);">+ bssgpPduType := '41'O,</span><br><span style="color: hsl(120, 100%, 40%);">+ cause := t_BSSGP_CAUSE(cause),</span><br><span style="color: hsl(120, 100%, 40%);">+ bVCI := bvci,</span><br><span style="color: hsl(120, 100%, 40%);">+ pDU_in_Error := {</span><br><span style="color: hsl(120, 100%, 40%);">+ iEI := '15'O,</span><br><span style="color: hsl(120, 100%, 40%);">+ ext := '1'B,</span><br><span style="color: hsl(120, 100%, 40%);">+ lengthIndicator := {</span><br><span style="color: hsl(120, 100%, 40%);">+ length1 := ?</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ erroneous_BSSGP_PDU := pdu</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> private function f_presence_bit_MultislotCap_GPRS_BSSGP(template (omit) MultislotCap_GPRS_BSSGP mscap_gprs) return BIT1 {</span><br><span> if (istemplatekind(mscap_gprs, "omit")) {</span><br><span> return '0'B;</span><br><span>@@ -1202,7 +1219,9 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- template PDU_BSSGP ts_BSSGP_DL_UD(GprsTlli tlli, octetstring pdu, template (omit) MSRadioAccessCapabilityV_BSSGP racap := omit) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ template PDU_BSSGP ts_BSSGP_DL_UD(GprsTlli tlli, octetstring pdu,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (omit) MSRadioAccessCapabilityV_BSSGP racap := omit,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (omit) IMSI_BSSGP imsi := omit) := {</span><br><span> pDU_BSSGP_DL_UNITDATA := {</span><br><span> bssgpPduType := '00'O,</span><br><span> tLLI_current := tlli,</span><br><span>@@ -1211,7 +1230,7 @@</span><br><span> mS_Radio_Access_Capability := ts_BSSGP_IE_MSRAcap_omit(racap),</span><br><span> priority := omit,</span><br><span> dRX_Parameters := omit,</span><br><span style="color: hsl(0, 100%, 40%);">- iMSI := omit,</span><br><span style="color: hsl(120, 100%, 40%);">+ iMSI := imsi,</span><br><span> tLLI_old := omit,</span><br><span> pFI := omit,</span><br><span> lSA_Information := omit,</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index bb10a77..c044957 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -1831,6 +1831,98 @@</span><br><span> f_tc_paging_ps_from_sgsn(mp_gb_cfg.bvci);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify osmo-pcu handles DL UNIT_DATA from SGSN with IMSI IE correctly. See OS#4729 */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_bssgp_dl_unitdata_with_valid_imsi() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var RlcmacDlBlock dl_block;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring data := f_rnd_octstring(10);</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t sched_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t dl_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var GprsMS ms;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_bssgp();</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize GPRS MS side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_gprs_ms();</span><br><span style="color: hsl(120, 100%, 40%);">+ ms := g_ms[0]; /* We only use first MS in this test */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_raw(testcasename());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish BSSGP connection to the PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_establish();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_llgmm_assign('FFFFFFFF'O, ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish an Uplink TBF */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_establish_ul_tbf(ms);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Fake GMM GPRS Attach or similar, PCU doesn't care about upper layers here */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UL block should be received in SGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.cell_id));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Now SGSN sends some DL data, PCU will page on CCCH (PCH) */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, imsi := ts_BSSGP_IMSI(ms.imsi)));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(X2002);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* ACK the DL block */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block, '1'B);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLCMAC_DL_ACK_NACK(ms.dl_tbf.tfi, ms.dl_tbf.acknack_desc),</span><br><span style="color: hsl(120, 100%, 40%);">+ f_dl_block_ack_fn(dl_block, dl_fn));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify osmo-pcu acts on incorrect IMSI IE content in DL UNIT_DATA from SGSN. See OS#4729 */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_bssgp_dl_unitdata_with_invalid_imsi() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var RlcmacDlBlock dl_block;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring data := f_rnd_octstring(10);</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t sched_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint32_t dl_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var GprsMS ms;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_bssgp();</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize GPRS MS side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_gprs_ms();</span><br><span style="color: hsl(120, 100%, 40%);">+ ms := g_ms[0]; /* We only use first MS in this test */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_raw(testcasename());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish BSSGP connection to the PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_establish();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_llgmm_assign('FFFFFFFF'O, ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish an Uplink TBF */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_establish_ul_tbf(ms);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Fake GMM GPRS Attach or similar, PCU doesn't care about upper layers here */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* DL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* UL block should be received in SGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.cell_id));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Now SGSN sends some DL data with an invalid IMSI */</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, imsi := ts_BSSGP_IMSI('1122'H)));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP_SIG[0].receive(tr_BSSGP_STATUS(omit, BSSGP_CAUSE_CONDITIONAL_IE_ERROR, ?));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO: make sure no data is sent over PCU -> MS */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> private function f_TC_egprs_pkt_chan_req(in EGPRSPktChRequest req,</span><br><span> template GsmRrMessage t_imm_ass := ?,</span><br><span> PCUIF_BurstType bt := BURST_TYPE_1)</span><br><span>@@ -2359,6 +2451,8 @@</span><br><span> execute( TC_paging_ps_from_sgsn_sign_ptmsi() );</span><br><span> execute( TC_paging_ps_from_sgsn_sign() );</span><br><span> execute( TC_paging_ps_from_sgsn_ptp() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_bssgp_dl_unitdata_with_valid_imsi() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_bssgp_dl_unitdata_with_invalid_imsi() );</span><br><span> </span><br><span> /* EGPRS specific test cases */</span><br><span> execute( TC_egprs_pkt_chan_req_signalling() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19854">change 19854</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19854"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5072d80b7ed9945a6083cdf3254efb8b8f119c54 </div>
<div style="display:none"> Gerrit-Change-Number: 19854 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>