<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19845">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lapd_test: rename func=UA (RR) CM Service Request: s/ua/ua_cm/<br><br>This is basically an ACKnowledgement for (RR) CM Service Request,<br>thus it contains a copy of the original Uplink message (cm).<br>Let's rename it to reflect this explicitly.<br><br>Change-Id: Id497ff4b688528916495387d64915b14396a68f1<br>---<br>M tests/lapd/lapd_test.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/19845/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/lapd/lapd_test.c b/tests/lapd/lapd_test.c</span><br><span>index 8a15b6d..f1659ef 100644</span><br><span>--- a/tests/lapd/lapd_test.c</span><br><span>+++ b/tests/lapd/lapd_test.c</span><br><span>@@ -67,7 +67,7 @@</span><br><span>         0x29, 0x47, 0x80, 0x00, 0x00, 0x00, 0x00, 0x80,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static const uint8_t ua[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+static const uint8_t ua_cm[] = {</span><br><span>     0x01, 0x73, 0x41, 0x05, 0x24, 0x31, 0x03, 0x50,</span><br><span>      0x18, 0x93, 0x08, 0x29, 0x47, 0x80, 0x00, 0x00,</span><br><span>      0x00, 0x00, 0x80, 0x2b, 0x2b, 0x2b, 0x2b</span><br><span>@@ -491,7 +491,7 @@</span><br><span>       send_sabm(&bts_to_ms_channel, 0, cm, sizeof(cm));</span><br><span>        rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH");</span><br><span>     CHECK_RC(rc);</span><br><span style="color: hsl(0, 100%, 40%);">-   OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua_cm, ARRAY_SIZE(ua_cm)) == 0);</span><br><span>      msgb_free(pp.oph.msg);</span><br><span> </span><br><span>   /* Send SABM MS 2, we must get nothing, due to collision */</span><br><span>@@ -507,7 +507,7 @@</span><br><span>    send_sabm(&bts_to_ms_channel, 0, cm, sizeof(cm));</span><br><span>        rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH");</span><br><span>     CHECK_RC(rc);</span><br><span style="color: hsl(0, 100%, 40%);">-   OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua_cm, ARRAY_SIZE(ua_cm)) == 0);</span><br><span>      msgb_free(pp.oph.msg);</span><br><span> </span><br><span>   /* clean up */</span><br><span>@@ -698,7 +698,7 @@</span><br><span> </span><br><span>     rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH");</span><br><span>     CHECK_RC(rc);</span><br><span style="color: hsl(0, 100%, 40%);">-   OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua_cm, ARRAY_SIZE(ua_cm)) == 0);</span><br><span>      msgb_free(pp.oph.msg);</span><br><span> </span><br><span>   printf("\nSending Classmark Change\n");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19845">change 19845</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19845"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id497ff4b688528916495387d64915b14396a68f1 </div>
<div style="display:none"> Gerrit-Change-Number: 19845 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>