<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19832">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CBC VTY: tweak VTY doc strings<br><br>Change-Id: I434835ae8dad9e726f296e648b1b55fb00be8ccb<br>---<br>M src/osmo-bsc/cbsp_link.c<br>1 file changed, 11 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/19832/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c</span><br><span>index d93bd1a..6a0884e 100644</span><br><span>--- a/src/osmo-bsc/cbsp_link.c</span><br><span>+++ b/src/osmo-bsc/cbsp_link.c</span><br><span>@@ -301,10 +301,11 @@</span><br><span>      return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define CBSP_REMOTE "Configure OsmoBSC as CBSP client towards a Cell Broadcast Centre (outbound TCP connection)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(cfg_cbc_remote_ip, cfg_cbc_remote_ip_cmd,</span><br><span>      "remote-ip A.B.C.D",</span><br><span style="color: hsl(0, 100%, 40%);">-  "IP Address of the Cell Broadcast Centre\n"</span><br><span style="color: hsl(0, 100%, 40%);">-   "IP Address of the Cell Broadcast Centre\n")</span><br><span style="color: hsl(120, 100%, 40%);">+        CBSP_REMOTE "IP Address of the Cell Broadcast Centre\n")</span><br><span> {</span><br><span>      struct bsc_cbc_link *cbc = vty_cbc_data(vty);</span><br><span>        osmo_talloc_replace_string(cbc, &cbc->config.cbc_hostname, argv[0]);</span><br><span>@@ -312,7 +313,7 @@</span><br><span> }</span><br><span> DEFUN(cfg_cbc_no_remote_ip, cfg_cbc_no_remote_ip_cmd,</span><br><span>      "no remote-ip",</span><br><span style="color: hsl(0, 100%, 40%);">-       NO_STR "Remove IP address of CBC; disables outbound CBSP connections\n")</span><br><span style="color: hsl(120, 100%, 40%);">+    NO_STR "Disable the CBSP client mode, disable outbound CBSP connections\n")</span><br><span> {</span><br><span>   struct bsc_cbc_link *cbc = vty_cbc_data(vty);</span><br><span>        talloc_free(cbc->config.cbc_hostname);</span><br><span>@@ -322,17 +323,19 @@</span><br><span> </span><br><span> DEFUN(cfg_cbc_remote_port, cfg_cbc_remote_port_cmd,</span><br><span>         "remote-port <1-65535>",</span><br><span style="color: hsl(0, 100%, 40%);">-        "TCP Port number of the Cell Broadcast Centre (Default: 48049)\n"</span><br><span style="color: hsl(0, 100%, 40%);">-     "TCP Port number of the Cell Broadcast Centre (Default: 48049)\n")</span><br><span style="color: hsl(120, 100%, 40%);">+  CBSP_REMOTE</span><br><span style="color: hsl(120, 100%, 40%);">+   "TCP Port number of the remote Cell Broadcast Centre (Default: 48049)\n")</span><br><span> {</span><br><span>     struct bsc_cbc_link *cbc = vty_cbc_data(vty);</span><br><span>        cbc->config.cbc_port = atoi(argv[0]);</span><br><span>     return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define CBSP_LISTEN "Configure OsmoBSC as CBSP server towards a Cell Broadcast Centre (inbound TCP connection)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(cfg_cbc_listen_port, cfg_cbc_listen_port_cmd,</span><br><span>   "listen-port <1-65535>",</span><br><span style="color: hsl(0, 100%, 40%);">-        "Local TCP port at which BSC listens for incoming CBSP connections from CBC\n"</span><br><span style="color: hsl(120, 100%, 40%);">+      CBSP_LISTEN</span><br><span>  "Local TCP port at which BSC listens for incoming CBSP connections from CBC\n")</span><br><span> {</span><br><span>       struct bsc_cbc_link *cbc = vty_cbc_data(vty);</span><br><span>@@ -350,8 +353,8 @@</span><br><span> </span><br><span> DEFUN(cfg_cbc_listen_ip, cfg_cbc_listen_ip_cmd,</span><br><span>   "listen-ip A.B.C.D",</span><br><span style="color: hsl(0, 100%, 40%);">-  "Local IP Address where BSC listens for incoming CBC connections (Default: 0.0.0.0)\n"</span><br><span style="color: hsl(0, 100%, 40%);">-        "Local IP Address where BSC listens for incoming CBC connections\n")</span><br><span style="color: hsl(120, 100%, 40%);">+        CBSP_LISTEN</span><br><span style="color: hsl(120, 100%, 40%);">+   "Local IP Address where BSC listens for incoming CBC connections (Default: 0.0.0.0)\n")</span><br><span> {</span><br><span>       struct bsc_cbc_link *cbc = vty_cbc_data(vty);</span><br><span>        osmo_talloc_replace_string(cbc, &cbc->config.listen_hostname, argv[0]);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19832">change 19832</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19832"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I434835ae8dad9e726f296e648b1b55fb00be8ccb </div>
<div style="display:none"> Gerrit-Change-Number: 19832 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>