<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19824">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix bsc_sapi_n_reject(): dlci is unsigned, use uint8_t<br><br>Change-Id: I5f04f16caecb58a28e119512267999fdc18ff172<br>---<br>M include/osmocom/bsc/gsm_08_08.h<br>M src/osmo-bsc/gsm_08_08.c<br>M tests/bsc/bsc_test.c<br>M tests/handover/handover_test.c<br>4 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/19824/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_08_08.h b/include/osmocom/bsc/gsm_08_08.h</span><br><span>index b46a8d3..e55bf2c 100644</span><br><span>--- a/include/osmocom/bsc/gsm_08_08.h</span><br><span>+++ b/include/osmocom/bsc/gsm_08_08.h</span><br><span>@@ -6,7 +6,7 @@</span><br><span> </span><br><span> struct gsm_subscriber_connection;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci);</span><br><span style="color: hsl(120, 100%, 40%);">+void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, uint8_t dlci);</span><br><span> void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb *msg, uint8_t chosen_encr);</span><br><span> int bsc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg, uint16_t chosen_channel);</span><br><span> void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg);</span><br><span>diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c</span><br><span>index e7ef728..e5457c4 100644</span><br><span>--- a/src/osmo-bsc/gsm_08_08.c</span><br><span>+++ b/src/osmo-bsc/gsm_08_08.c</span><br><span>@@ -60,7 +60,7 @@</span><br><span> }</span><br><span> </span><br><span> /*! BTS->MSC: tell MSC a SAPI was not established. */</span><br><span style="color: hsl(0, 100%, 40%);">-void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci)</span><br><span style="color: hsl(120, 100%, 40%);">+void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, uint8_t dlci)</span><br><span> {</span><br><span>        int rc;</span><br><span>      struct msgb *resp;</span><br><span>diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c</span><br><span>index dd2b1bb..86d8972 100644</span><br><span>--- a/tests/bsc/bsc_test.c</span><br><span>+++ b/tests/bsc/bsc_test.c</span><br><span>@@ -223,7 +223,7 @@</span><br><span>        OSMO_ASSERT(0);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci) {}</span><br><span style="color: hsl(120, 100%, 40%);">+void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, uint8_t dlci) {}</span><br><span> void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb *msg, uint8_t chosen_encr) {}</span><br><span> int bsc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg, uint16_t chosen_channel)</span><br><span> { return 0; }</span><br><span>diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c</span><br><span>index 6fb145e..31d4b6f 100644</span><br><span>--- a/tests/handover/handover_test.c</span><br><span>+++ b/tests/handover/handover_test.c</span><br><span>@@ -1794,7 +1794,7 @@</span><br><span> void trau_send_frame() {}</span><br><span> int osmo_bsc_sigtran_send(struct gsm_subscriber_connection *conn, struct msgb *msg) { return 0; }</span><br><span> int osmo_bsc_sigtran_open_conn(struct gsm_subscriber_connection *conn, struct msgb *msg) { return 0; }</span><br><span style="color: hsl(0, 100%, 40%);">-void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci) {}</span><br><span style="color: hsl(120, 100%, 40%);">+void bsc_sapi_n_reject(struct gsm_subscriber_connection *conn, uint8_t dlci) {}</span><br><span> void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb *msg, uint8_t chosen_encr) {}</span><br><span> int bsc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg, uint16_t chosen_channel)</span><br><span> { return 0; }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19824">change 19824</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19824"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5f04f16caecb58a28e119512267999fdc18ff172 </div>
<div style="display:none"> Gerrit-Change-Number: 19824 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>