<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19841">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">macaddr: fix osmo_macaddr_parse(): return meaningful error codes<br><br>Change-Id: I316deb83979198acc26721d29708d9942174b192<br>---<br>M src/macaddr.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/19841/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/macaddr.c b/src/macaddr.c</span><br><span>index a9138f8..56fdf86 100644</span><br><span>--- a/src/macaddr.c</span><br><span>+++ b/src/macaddr.c</span><br><span>@@ -34,6 +34,7 @@</span><br><span> #include <string.h></span><br><span> #include <stdlib.h></span><br><span> #include <unistd.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <errno.h></span><br><span> </span><br><span> /*! Parse a MAC address from human-readable notation</span><br><span>  *  This function parses an ethernet MAC address in the commonly-used</span><br><span>@@ -77,11 +78,11 @@</span><br><span>  */</span><br><span> int osmo_get_macaddr(uint8_t *mac_out, const char *dev_name)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   int rc = -1;</span><br><span>         struct ifaddrs *ifa, *ifaddr;</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc = -ENODEV;</span><br><span> </span><br><span>        if (getifaddrs(&ifaddr) != 0)</span><br><span style="color: hsl(0, 100%, 40%);">-               return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+            return -errno;</span><br><span> </span><br><span>   for (ifa = ifaddr; ifa != NULL; ifa = ifa->ifa_next) {</span><br><span>            struct sockaddr_dl *sdl;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19841">change 19841</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19841"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I316deb83979198acc26721d29708d9942174b192 </div>
<div style="display:none"> Gerrit-Change-Number: 19841 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>