<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19632">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  neels: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CBSP: on RESET, also clear the etws_timer, and stop ETWS PN broadcast<br><br>Normally, each ETWS CMD instructing to broadcast triggers a five second<br>etws_timer to send a zero-payload ETWS CMD that stops broadcasting, five<br>seconds later. Before this patch, this lingered past an ETWS RESET instruction.<br><br>Instead, clear the etws_timer on ETWS RESET, and make sure that all ETWS PN<br>broadcast is stopped by sending a zero payload ETWS CMD to the BTSes<br>immediately.<br><br>This will cause all CBSP ttcn3 tests to fail unless<br>Ifee313369a433a6a638c5fffdedee5363b8e47c2 is merged to osmo-ttcn3-hacks at the<br>same time.<br><br>Related: Ifee313369a433a6a638c5fffdedee5363b8e47c2 (osmo-ttcn3-hacks)<br>Change-Id: I925a041936c6163483d70fe6d158af368ec8c444<br>---<br>M src/osmo-bsc/smscb.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c</span><br><span>index 436826a..cb68578 100644</span><br><span>--- a/src/osmo-bsc/smscb.c</span><br><span>+++ b/src/osmo-bsc/smscb.c</span><br><span>@@ -664,6 +664,10 @@</span><br><span>  llist_for_each_entry_safe(smscb, smscb2, &chan_state->messages, list)</span><br><span>                 bts_smscb_del(smscb, chan_state, "RESET");</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      osmo_timer_del(&bts->etws_timer);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    /* Make sure that broadcast is disabled */</span><br><span style="color: hsl(120, 100%, 40%);">+    rsl_etws_pn_command(bts, RSL_CHAN_PCH_AGCH, NULL, 0);</span><br><span>        return 0;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19632">change 19632</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19632"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I925a041936c6163483d70fe6d158af368ec8c444 </div>
<div style="display:none"> Gerrit-Change-Number: 19632 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>