<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19749">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSC_Tests_CBSP.ttcn: Fix tons of compiler warnings<br><br>the argument given to tr_ASP_RSL_UD() needs a 'present' qualifier, as it<br>cannot be 'omit'<br><br> BSC_Tests_CBSP.ttcn:524.1-537.1: In testcase definition `TC_cbsp_write_lac':<br> BSC_Tests_CBSP.ttcn:532.2-535.2: In interleave statement:<br> BSC_Tests_CBSP.ttcn:533.5-41: In guard operation:<br> BSC_Tests_CBSP.ttcn:533.5-41: In receive statement:<br> BSC_Tests_CBSP.ttcn:533.37-40: In actual parameter list of template `@IPA_Emulation.tr_ASP_RSL_UD':<br> BSC_Tests_CBSP.ttcn:533.38-39: In parameter #1 for `rsl':<br> BSC_Tests_CBSP.ttcn:533.38-39: warning: Inadequate restriction on the referenced template variable `tr', this may cause a dynamic test case error at runtime<br> BSC_Tests_CBSP.ttcn:531.27-82: note: Referenced template variable is here<br> BSC_Tests_CBSP.ttcn:534.5-41: In guard operation:<br> BSC_Tests_CBSP.ttcn:534.5-41: In receive statement:<br> BSC_Tests_CBSP.ttcn:534.37-40: In actual parameter list of template `@IPA_Emulation.tr_ASP_RSL_UD':<br> BSC_Tests_CBSP.ttcn:534.38-39: In parameter #1 for `rsl':<br> BSC_Tests_CBSP.ttcn:534.38-39: warning: Inadequate restriction on the referenced template variable `tr', this may cause a dynamic test case error at runtime<br> BSC_Tests_CBSP.ttcn:531.27-82: note: Referenced template variable is here<br><br>Change-Id: Id64e8e135b690c34293487304d7a175b5b56265b<br>---<br>M bsc/BSC_Tests_CBSP.ttcn<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn</span><br><span>index 497ff80..548c0c1 100644</span><br><span>--- a/bsc/BSC_Tests_CBSP.ttcn</span><br><span>+++ b/bsc/BSC_Tests_CBSP.ttcn</span><br><span>@@ -79,14 +79,14 @@</span><br><span> log("g_cbsp_msg_id=", g_cbsp_msg_id, " g_cbsp_ser_no=", g_cbsp_ser_no);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-private altstep as_IgnRSL(template RSL_Message tr) runs on cbsp_test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+private altstep as_IgnRSL(template (present) RSL_Message tr) runs on cbsp_test_CT {</span><br><span> [] IPA_RSL[0].receive(tr_ASP_RSL_UD(tr)) { repeat; }</span><br><span> [] IPA_RSL[1].receive(tr_ASP_RSL_UD(tr)) { repeat; }</span><br><span> [] IPA_RSL[2].receive(tr_ASP_RSL_UD(tr)) { repeat; }</span><br><span> }</span><br><span> </span><br><span> private altstep as_FailRSL() runs on cbsp_test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-var template RSL_Message tr := (tr_RSL_SMSCB_CMD);</span><br><span style="color: hsl(120, 100%, 40%);">+var template (present) RSL_Message tr := (tr_RSL_SMSCB_CMD);</span><br><span> var ASP_RSL_Unitdata rx;</span><br><span> [] IPA_RSL[0].receive(tr_ASP_RSL_UD(tr)) -> value rx {</span><br><span> setverdict(fail, "Received unexpected RSL ", rx);</span><br><span>@@ -334,7 +334,7 @@</span><br><span> template (present) integer expect_blocks := ?)</span><br><span> return template (present) RSL_Message</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- var template RSL_Message tr;</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (present) RSL_Message tr;</span><br><span> var integer len;</span><br><span> var integer num_blocks;</span><br><span> var octetstring payload;</span><br><span>@@ -407,7 +407,7 @@</span><br><span> f_cbsp_write(g_cbsp_msg_id, g_cbsp_ser_no, cell_list, content:=pages,</span><br><span> success_list:=tr_BSSMAP_CIL_CGI({?,?,?}), fail_list:={?});</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- var template RSL_Message tr := f_page2rsl(pages[0], g_cbsp_msg_id, g_cbsp_ser_no, expect_blocks := expect_blocks);</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (present) RSL_Message tr := f_page2rsl(pages[0], g_cbsp_msg_id, g_cbsp_ser_no, expect_blocks := expect_blocks);</span><br><span> log("RSL[0,1,2] EXPECTING ", tr_ASP_RSL_UD(tr));</span><br><span> interleave {</span><br><span> [] IPA_RSL[0].receive(tr_ASP_RSL_UD(tr)) { log("Got SMSCB CMD on RSL[0]"); }</span><br><span>@@ -453,7 +453,7 @@</span><br><span> f_cbsp_init_server(2001, 2501);</span><br><span> f_cbsp_write(g_cbsp_msg_id, g_cbsp_ser_no, cell_list, content:=pages,</span><br><span> success_list:=cell_list, fail_list:=omit);</span><br><span style="color: hsl(0, 100%, 40%);">- var template RSL_Message tr := f_page2rsl(pages[0], g_cbsp_msg_id, g_cbsp_ser_no);</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (present) RSL_Message tr := f_page2rsl(pages[0], g_cbsp_msg_id, g_cbsp_ser_no);</span><br><span> IPA_RSL[0].receive(tr_ASP_RSL_UD(tr));</span><br><span> f_sleep(5.0);</span><br><span> }</span><br><span>@@ -528,7 +528,7 @@</span><br><span> f_cbsp_init_server(8001, 8501);</span><br><span> f_cbsp_write(g_cbsp_msg_id, g_cbsp_ser_no, cell_list, content:=pages,</span><br><span> success_list:=?, fail_list:=omit);</span><br><span style="color: hsl(0, 100%, 40%);">- var template RSL_Message tr := f_page2rsl(pages[0], g_cbsp_msg_id, g_cbsp_ser_no);</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (present) RSL_Message tr := f_page2rsl(pages[0], g_cbsp_msg_id, g_cbsp_ser_no);</span><br><span> interleave {</span><br><span> [] IPA_RSL[0].receive(tr_ASP_RSL_UD(tr));</span><br><span> [] IPA_RSL[1].receive(tr_ASP_RSL_UD(tr));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19749">change 19749</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19749"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id64e8e135b690c34293487304d7a175b5b56265b </div>
<div style="display:none"> Gerrit-Change-Number: 19749 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>