<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19716">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: Fix repeated execution of TC_sgsap_unsol_ud()<br><br>Change-Id: I6c2f1a5d5b5316ffe462335f8461c31564ce4274<br>Closes: OS#4722<br>---<br>M msc/MSC_Tests.ttcn<br>1 file changed, 14 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index bdd9f62..a801db9 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -962,23 +962,27 @@</span><br><span>       vc_conn.done;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* Test IMSI DETACH (MI=IMSI) */</span><br><span style="color: hsl(0, 100%, 40%);">-friend function f_tc_imsi_detach_by_imsi(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span style="color: hsl(0, 100%, 40%);">-     f_init_handler(pars);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_imsi_detach_by_imsi() runs on BSC_ConnHdlr {</span><br><span>        var MobileIdentityLV mi := valueof(ts_MI_IMSI_LV(g_pars.imsi));</span><br><span> </span><br><span>  /* Send BSSAP_Conn_Req with COMPL L3 INFO to MSC */</span><br><span>  f_cl3_or_initial_ue(valueof(ts_ML3_MO_MM_IMSI_DET_Ind(mi)));</span><br><span> </span><br><span>     /* Send Early Classmark, just for the fun of it? */</span><br><span style="color: hsl(0, 100%, 40%);">-     if (pars.ran_is_geran) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (g_pars.ran_is_geran) {</span><br><span>           BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3));</span><br><span>  }</span><br><span> </span><br><span>        /* wait for normal teardown */</span><br><span style="color: hsl(0, 100%, 40%);">-  f_expect_clear();</span><br><span style="color: hsl(120, 100%, 40%);">+     f_expect_clear(verify_vlr_cell_id := false);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Test IMSI DETACH (MI=IMSI) */</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_tc_imsi_detach_by_imsi(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+  f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       f_imsi_detach_by_imsi();</span><br><span> }</span><br><span> testcase TC_imsi_detach_by_imsi() runs on MTC_CT {</span><br><span>  var BSC_ConnHdlr vc_conn;</span><br><span>@@ -4831,6 +4835,9 @@</span><br><span> </span><br><span>        f_sgsap_bssmap_screening();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+       /* clean-up VLR state about this subscriber */</span><br><span style="color: hsl(120, 100%, 40%);">+        f_imsi_detach_by_imsi();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   setverdict(pass);</span><br><span> }</span><br><span> testcase TC_sgsap_unsol_ud() runs on MTC_CT {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19716">change 19716</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19716"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6c2f1a5d5b5316ffe462335f8461c31564ce4274 </div>
<div style="display:none"> Gerrit-Change-Number: 19716 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>