<p>daniel <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19740">View Change</a></p><div style="white-space:pre-wrap">Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove punctuation in counter description<br><br>Change-Id: I304dcc9e88afc5e607d5b010df3e95f40fb8c49b<br>---<br>M include/osmocom/bsc/gsm_data.h<br>1 file changed, 34 insertions(+), 34 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index cfed1f8..9fdefc4 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -992,56 +992,56 @@</span><br><span> };</span><br><span> </span><br><span> static const struct rate_ctr_desc bsc_ctr_description[] = {</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_ASSIGNMENT_ATTEMPTED] = {"assignment:attempted", "Assignment attempts."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_ASSIGNMENT_COMPLETED] = {"assignment:completed", "Assignment completed."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_ASSIGNMENT_STOPPED] = {"assignment:stopped", "Connection ended during Assignment."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_ASSIGNMENT_NO_CHANNEL] = {"assignment:no_channel", "Failure to allocate lchan for Assignment."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_ASSIGNMENT_TIMEOUT] = {"assignment:timeout", "Assignment timed out."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_ASSIGNMENT_FAILED] = {"assignment:failed", "Received Assignment Failure message."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_ASSIGNMENT_ERROR] = {"assignment:error", "Assignment failed for other reason."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_ASSIGNMENT_ATTEMPTED] = {"assignment:attempted", "Assignment attempts"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_ASSIGNMENT_COMPLETED] = {"assignment:completed", "Assignment completed"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_ASSIGNMENT_STOPPED] = {"assignment:stopped", "Connection ended during Assignment"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_ASSIGNMENT_NO_CHANNEL] = {"assignment:no_channel", "Failure to allocate lchan for Assignment"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_ASSIGNMENT_TIMEOUT] = {"assignment:timeout", "Assignment timed out"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_ASSIGNMENT_FAILED] = {"assignment:failed", "Received Assignment Failure message"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_ASSIGNMENT_ERROR] = {"assignment:error", "Assignment failed for other reason"},</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_HANDOVER_ATTEMPTED] = {"handover:attempted", "Intra-BSC handover attempts."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_HANDOVER_COMPLETED] = {"handover:completed", "Intra-BSC handover completed."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_HANDOVER_STOPPED] = {"handover:stopped", "Connection ended during HO."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_HANDOVER_NO_CHANNEL] = {"handover:no_channel", "Failure to allocate lchan for HO."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_HANDOVER_TIMEOUT] = {"handover:timeout", "Handover timed out."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_HANDOVER_FAILED] = {"handover:failed", "Received Handover Fail messages."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_HANDOVER_ERROR] = {"handover:error", "Re-assignment failed for other reason."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_HANDOVER_ATTEMPTED] = {"handover:attempted", "Intra-BSC handover attempts"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_HANDOVER_COMPLETED] = {"handover:completed", "Intra-BSC handover completed"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_HANDOVER_STOPPED] = {"handover:stopped", "Connection ended during HO"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_HANDOVER_NO_CHANNEL] = {"handover:no_channel", "Failure to allocate lchan for HO"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_HANDOVER_TIMEOUT] = {"handover:timeout", "Handover timed out"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_HANDOVER_FAILED] = {"handover:failed", "Received Handover Fail messages"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_HANDOVER_ERROR] = {"handover:error", "Re-assignment failed for other reason"},</span><br><span> </span><br><span> [BSC_CTR_INTER_BSC_HO_OUT_ATTEMPTED] = {"interbsc_ho_out:attempted",</span><br><span style="color: hsl(0, 100%, 40%);">- "Attempts to handover to remote BSS."},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Attempts to handover to remote BSS"},</span><br><span> [BSC_CTR_INTER_BSC_HO_OUT_COMPLETED] = {"interbsc_ho_out:completed",</span><br><span style="color: hsl(0, 100%, 40%);">- "Handover to remote BSS completed."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_INTER_BSC_HO_OUT_STOPPED] = {"interbsc_ho_out:stopped", "Connection ended during HO."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_INTER_BSC_HO_OUT_TIMEOUT] = {"interbsc_ho_out:timeout", "Handover timed out."},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Handover to remote BSS completed"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_INTER_BSC_HO_OUT_STOPPED] = {"interbsc_ho_out:stopped", "Connection ended during HO"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_INTER_BSC_HO_OUT_TIMEOUT] = {"interbsc_ho_out:timeout", "Handover timed out"},</span><br><span> [BSC_CTR_INTER_BSC_HO_OUT_ERROR] = {"interbsc_ho_out:error",</span><br><span style="color: hsl(0, 100%, 40%);">- "Handover to remote BSS failed for other reason."},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Handover to remote BSS failed for other reason"},</span><br><span> </span><br><span> [BSC_CTR_INTER_BSC_HO_IN_ATTEMPTED] = {"interbsc_ho_in:attempted",</span><br><span style="color: hsl(0, 100%, 40%);">- "Attempts to handover from remote BSS."},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Attempts to handover from remote BSS"},</span><br><span> [BSC_CTR_INTER_BSC_HO_IN_COMPLETED] = {"interbsc_ho_in:completed",</span><br><span style="color: hsl(0, 100%, 40%);">- "Handover from remote BSS completed."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_INTER_BSC_HO_IN_STOPPED] = {"interbsc_ho_in:stopped", "Connection ended during HO."},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Handover from remote BSS completed"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_INTER_BSC_HO_IN_STOPPED] = {"interbsc_ho_in:stopped", "Connection ended during HO"},</span><br><span> [BSC_CTR_INTER_BSC_HO_IN_NO_CHANNEL] = {"interbsc_ho_in:no_channel",</span><br><span style="color: hsl(0, 100%, 40%);">- "Failure to allocate lchan for HO."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_INTER_BSC_HO_IN_TIMEOUT] = {"interbsc_ho_in:timeout", "Handover from remote BSS timed out."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_INTER_BSC_HO_IN_FAILED] = {"interbsc_ho_in:failed", "Received Handover Fail message."},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Failure to allocate lchan for HO"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_INTER_BSC_HO_IN_TIMEOUT] = {"interbsc_ho_in:timeout", "Handover from remote BSS timed out"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_INTER_BSC_HO_IN_FAILED] = {"interbsc_ho_in:failed", "Received Handover Fail message"},</span><br><span> [BSC_CTR_INTER_BSC_HO_IN_ERROR] = {"interbsc_ho_in:error",</span><br><span style="color: hsl(0, 100%, 40%);">- "Handover from remote BSS failed for other reason."},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Handover from remote BSS failed for other reason"},</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_PAGING_ATTEMPTED] = {"paging:attempted", "Paging attempts for a subscriber."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_PAGING_DETACHED] = {"paging:detached", "Paging request send failures because no responsible BTS was found."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_PAGING_RESPONDED] = {"paging:responded", "Paging attempts with successful response."},</span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging", "Paging response without an active paging request (arrived after paging expiration?)."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_PAGING_ATTEMPTED] = {"paging:attempted", "Paging attempts for a subscriber"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_PAGING_DETACHED] = {"paging:detached", "Paging request send failures because no responsible BTS was found"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_PAGING_RESPONDED] = {"paging:responded", "Paging attempts with successful response"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging", "Paging response without an active paging request (arrived after paging expiration?)"},</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- [BSC_CTR_UNKNOWN_UNIT_ID] = {"abis:unknown_unit_id", "Connection attempts from unknown IPA CCM Unit ID."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BSC_CTR_UNKNOWN_UNIT_ID] = {"abis:unknown_unit_id", "Connection attempts from unknown IPA CCM Unit ID"},</span><br><span> </span><br><span> [BSC_CTR_MSCPOOL_SUBSCR_NO_MSC] = {"mscpool:subscr:no_msc",</span><br><span style="color: hsl(0, 100%, 40%);">- "Complete Layer 3 requests lost because no connected MSC is found available."},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Complete Layer 3 requests lost because no connected MSC is found available"},</span><br><span> [BSC_CTR_MSCPOOL_EMERG_FORWARDED] = {"mscpool:emerg:forwarded",</span><br><span style="color: hsl(0, 100%, 40%);">- "Emergency call requests forwarded to an MSC (see also per-MSC counters)"},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Emergency call requests forwarded to an MSC (see also per-MSC counters"},</span><br><span> [BSC_CTR_MSCPOOL_EMERG_LOST] = {"mscpool:emerg:lost",</span><br><span style="color: hsl(0, 100%, 40%);">- "Emergency call requests lost because no MSC was found available."},</span><br><span style="color: hsl(120, 100%, 40%);">+ "Emergency call requests lost because no MSC was found available"},</span><br><span> };</span><br><span> </span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19740">change 19740</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19740"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I304dcc9e88afc5e607d5b010df3e95f40fb8c49b </div>
<div style="display:none"> Gerrit-Change-Number: 19740 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>