<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/include/osmocom/bsc/bts.h">File include/osmocom/bsc/bts.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/include/osmocom/bsc/bts.h@90">Patch Set #1, Line 90:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Drop empty line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/include/osmocom/bsc/bts.h@150">Patch Set #1, Line 150:</a> <code style="font-family:monospace,monospace"> [BTS_CTR_HANDOVER_ATTEMPTED] =          {"handover:attempted", "Intra-BSC handover attempts."},</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Drop dots at the end of description.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/src/osmo-bsc/handover_fsm.c">File src/osmo-bsc/handover_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/src/osmo-bsc/handover_fsm.c@91">Patch Set #1, Line 91:</a> <code style="font-family:monospace,monospace"> * Assume conn_get_bts() is not NULL</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No conn_get_bts used here...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/src/osmo-bsc/handover_fsm.c@93">Patch Set #1, Line 93:</a> <code style="font-family:monospace,monospace">#define ho_count_bts(bts, counter) do { \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">so if bts=NULL you log you increment the rate_ctr but you don't do it...</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736/1/src/osmo-bsc/handover_fsm.c@630">Patch Set #1, Line 630:</a> <code style="font-family:monospace,monospace">   ho_count_bsc(BSC_CTR_INTER_BSC_HO_IN_ATTEMPTED);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You can use ho_count() here for both.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736">change 19736</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19736"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I025ef14e2cfd2eea8880212c9406372ce0bf9296 </div>
<div style="display:none"> Gerrit-Change-Number: 19736 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Jenkins Builder </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 20 Aug 2020 15:40:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>