<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19701">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty/command: cosmetic: swap i and j in vty_dump_element()<br><br>It's more convenient to use i in the outer loop, and j, k, etc.<br>in the inner loops.  Otherwise it looks a bit confusing.<br><br>Change-Id: I61ef48fcf977d6a872e288571a4ff2c3dfe3184b<br>---<br>M src/vty/command.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/19701/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index d5e9d27..722b3e0 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -632,13 +632,13 @@</span><br><span>      print_func(data, "    <command id='%s'>%s", xml_string, newline);</span><br><span>    print_func(data, "      <params>%s", newline);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      int j;</span><br><span style="color: hsl(0, 100%, 40%);">-  for (j = 0; j < vector_count(cmd->strvec); ++j) {</span><br><span style="color: hsl(0, 100%, 40%);">-         vector descvec = vector_slot(cmd->strvec, j);</span><br><span style="color: hsl(0, 100%, 40%);">-                int i;</span><br><span style="color: hsl(0, 100%, 40%);">-          for (i = 0; i < vector_active(descvec); ++i) {</span><br><span style="color: hsl(120, 100%, 40%);">+     int i;</span><br><span style="color: hsl(120, 100%, 40%);">+        for (i = 0; i < vector_count(cmd->strvec); ++i) {</span><br><span style="color: hsl(120, 100%, 40%);">+               vector descvec = vector_slot(cmd->strvec, i);</span><br><span style="color: hsl(120, 100%, 40%);">+              int j;</span><br><span style="color: hsl(120, 100%, 40%);">+                for (j = 0; j < vector_active(descvec); ++j) {</span><br><span>                    char *xml_param, *xml_doc;</span><br><span style="color: hsl(0, 100%, 40%);">-                      struct desc *desc = vector_slot(descvec, i);</span><br><span style="color: hsl(120, 100%, 40%);">+                  struct desc *desc = vector_slot(descvec, j);</span><br><span>                         if (desc == NULL)</span><br><span>                            continue;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19701">change 19701</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19701"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I61ef48fcf977d6a872e288571a4ff2c3dfe3184b </div>
<div style="display:none"> Gerrit-Change-Number: 19701 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>