<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19714">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: Expect CommonID from MSC by default<br><br>As of osmo-msc Change-Id I2552736477663adb250c55728093500e8ae83ebb,<br>osmo-msc is always sending BSSMAP CommonID to the BSC.  Let's adjust our<br>test expectation, while allowing the user to start the tests with<br>BSC_ConnectionHandler.mp_expect_common_id := false<br>to get the existing behavior (expect no bSSMAP CommonId) can be<br>restored, e.g. for testing 'latest'.<br><br>Change-Id: I4976d9bb1f07c8ab4ffa02848414f8ddd1bdfd3f<br>Related: OS#2969<br>---<br>M msc/BSC_ConnectionHandler.ttcn<br>1 file changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/19714/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn</span><br><span>index cc69a68..3d33ae7 100644</span><br><span>--- a/msc/BSC_ConnectionHandler.ttcn</span><br><span>+++ b/msc/BSC_ConnectionHandler.ttcn</span><br><span>@@ -61,6 +61,10 @@</span><br><span> </span><br><span> import from TCCConversion_Functions { function f_strstr };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+modulepar {</span><br><span style="color: hsl(120, 100%, 40%);">+ boolean mp_expect_common_id := true;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* this component represents a single subscriber connection */</span><br><span> type component BSC_ConnHdlr extends RAN_ConnHdlr, MNCC_ConnHdlr, GSUP_ConnHdlr, MGCP_ConnHdlr, SMPP_ConnHdlr, CTRL_Adapter_CT, SGsAP_ConnHdlr {</span><br><span>       var BSC_ConnHdlrPars g_pars;</span><br><span>@@ -539,6 +543,9 @@</span><br><span>                   }</span><br><span>                    /* FIXME: Send the best available algorithm */</span><br><span>               }</span><br><span style="color: hsl(120, 100%, 40%);">+             if (mp_expect_common_id) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    BSSAP.receive(tr_BSSMAP_CommonId(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+               }</span><br><span>    } else { /* UTRAN */</span><br><span>                 alt {</span><br><span>                [g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmdEnc(uia_algs := ?,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19714">change 19714</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19714"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4976d9bb1f07c8ab4ffa02848414f8ddd1bdfd3f </div>
<div style="display:none"> Gerrit-Change-Number: 19714 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>