<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19639">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty cpu sched: do not assert if sched impossible<br><br>Shared code might be used by applications that have no vty, so sched<br>can't be initialized, do not assert and break everything in this case, a<br>warning should suffice.<br><br>Change-Id: Ic40075df8d4cf9fe8f1d711f899dae9a4b5b0928<br>---<br>M src/vty/cpu_sched_vty.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/cpu_sched_vty.c b/src/vty/cpu_sched_vty.c</span><br><span>index 3b6067a..8cd11fe 100644</span><br><span>--- a/src/vty/cpu_sched_vty.c</span><br><span>+++ b/src/vty/cpu_sched_vty.c</span><br><span>@@ -469,7 +469,7 @@</span><br><span>     LOGP(DLGLOBAL, LOGL_NOTICE, "Setting SCHED_RR priority %d\n", param.sched_priority);</span><br><span>       rc = sched_setscheduler(getpid(), SCHED_RR, &param);</span><br><span>     if (rc == -1) {</span><br><span style="color: hsl(0, 100%, 40%);">-         LOGP(DLGLOBAL, LOGL_FATAL, "Setting SCHED_RR priority %d failed: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGP(DLGLOBAL, LOGL_ERROR, "Setting SCHED_RR priority %d failed: %s\n",</span><br><span>                 param.sched_priority, strerror(errno));</span><br><span>                 return -1;</span><br><span>   }</span><br><span>@@ -631,7 +631,10 @@</span><br><span>     int rc = 0;</span><br><span> </span><br><span>      /* Assert subsystem was inited and structs are preset */</span><br><span style="color: hsl(0, 100%, 40%);">-        OSMO_ASSERT(sched_vty_opts);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (!sched_vty_opts) {</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DLGLOBAL, LOGL_FATAL, "Setting cpu-affinity mask impossible: no opts!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+             return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span> </span><br><span>        if (pthread_getname_np(pthread_self(), name, sizeof(name)) == 0)</span><br><span>             has_name = true;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19639">change 19639</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19639"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic40075df8d4cf9fe8f1d711f899dae9a4b5b0928 </div>
<div style="display:none"> Gerrit-Change-Number: 19639 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>