<p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_shm.c">File Transceiver52M/device/ipc/ipc_shm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_shm.c@43">Patch Set #10, Line 43:</a> <code style="font-family:monospace,monospace">malloc</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can we use talloc here? (just wondering)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_sock.c">File Transceiver52M/device/ipc/ipc_sock.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_sock.c@59">Patch Set #10, Line 59:</a> <code style="font-family:monospace,monospace">              LOGP(DMAIN, LOGL_ERROR, "Received unknown IPC msg type %d\n", msg_type);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">0x%02x</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_sock.c@59">Patch Set #10, Line 59:</a> <code style="font-family:monospace,monospace">DMAIN</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DDEV?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc_sock.c@269">Patch Set #10, Line 269:</a> <code style="font-family:monospace,monospace">IPC_tx_info_ind</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why is it commented out? If it's not needed - please drop it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641">change 19641</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/19641"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ice63d3499026293ade8aad675ff7a883bcdd5756 </div>
<div style="display:none"> Gerrit-Change-Number: 19641 </div>
<div style="display:none"> Gerrit-PatchSet: 10 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 Aug 2020 18:00:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>