<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19143">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19143/13/include/osmocom/core/socket.h">File include/osmocom/core/socket.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19143/13/include/osmocom/core/socket.h@61">Patch Set #13, Line 61:</a> <code style="font-family:monospace,monospace">int osmo_sock_init3(uint16_t type, uint8_t proto,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't really like calling this one osmo_sock_init3, since it's not really an upgrade from previous versions but rather a different function with different parameter, scope of use and logic, as lynxis explained in a previous comment.<br>osmo_sock_init_sa() or similar looks like a better naming to me.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c">File src/socket.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c@465">Patch Set #13, Line 465:</a> <code style="font-family:monospace,monospace"> * This function creates a new socket of the designated \a family, \a</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No "family" parameter here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19143">change 19143</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19143"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1eece543e3241ef0e095eb63bb831f7c15a16794 </div>
<div style="display:none"> Gerrit-Change-Number: 19143 </div>
<div style="display:none"> Gerrit-PatchSet: 13 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 Aug 2020 11:16:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>