<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19618">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Bump version: 0.8.0.59-1f92-dirty → 1.0.0<br><br>Change-Id: Iffbb96739f53c7e005f440bc1615f158f7c661eb<br>---<br>M TODO-RELEASE<br>M configure.ac<br>M contrib/libosmo-abis.spec.in<br>M debian/changelog<br>M debian/control<br>R debian/libosmoabis9.install<br>M src/Makefile.am<br>7 files changed, 93 insertions(+), 25 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/TODO-RELEASE b/TODO-RELEASE</span><br><span>index bf3ef84..d0852fc 100644</span><br><span>--- a/TODO-RELEASE</span><br><span>+++ b/TODO-RELEASE</span><br><span>@@ -7,8 +7,3 @@</span><br><span> # If any interfaces have been added since the last public release: c:r:a + 1.</span><br><span> # If any interfaces have been removed or changed since the last public release: c:r:0.</span><br><span> #library what description / commit summary line</span><br><span style="color: hsl(0, 100%, 40%);">-libosmo-abis API change major: add parameter to struct e1inp_line</span><br><span style="color: hsl(0, 100%, 40%);">-libosmo-trau API change add new function osmo_rtp_socket_set_dscp()</span><br><span style="color: hsl(0, 100%, 40%);">-libosmo-abis API change major: add parameter to struct lapd_instance</span><br><span style="color: hsl(0, 100%, 40%);">-libosmo-abis Field added struct e1inp_line "use_count". REMINDER: Upon LIBVERSION c bump, take the chance to drop struct e1inp_line "refcnt" field.</span><br><span style="color: hsl(0, 100%, 40%);">-libosmo-abis libosmogsm dep Use of lapd_dl_init2() requires libosmocore > 1.3.0 (not yet released, 00b2faf8217338d4d7d1f4d27331af3151447350)</span><br><span>diff --git a/configure.ac b/configure.ac</span><br><span>index 04ffca6..9926f05 100644</span><br><span>--- a/configure.ac</span><br><span>+++ b/configure.ac</span><br><span>@@ -64,9 +64,9 @@</span><br><span> dnl Generate the output</span><br><span> AM_CONFIG_HEADER(config.h)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.1.0)</span><br><span style="color: hsl(0, 100%, 40%);">-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.1.0)</span><br><span style="color: hsl(0, 100%, 40%);">-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.1.0)</span><br><span style="color: hsl(120, 100%, 40%);">+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.4.0)</span><br><span style="color: hsl(120, 100%, 40%);">+PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.4.0)</span><br><span style="color: hsl(120, 100%, 40%);">+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.4.0)</span><br><span> PKG_CHECK_MODULES(ORTP, ortp >= 0.22.0)</span><br><span> </span><br><span> AC_ARG_ENABLE([dahdi],</span><br><span>diff --git a/contrib/libosmo-abis.spec.in b/contrib/libosmo-abis.spec.in</span><br><span>index da0c2d8..2a186a4 100644</span><br><span>--- a/contrib/libosmo-abis.spec.in</span><br><span>+++ b/contrib/libosmo-abis.spec.in</span><br><span>@@ -38,12 +38,12 @@</span><br><span> BSC. This interface allows control of the radio equipment and radio</span><br><span> frequency allocation in the BTS.</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-%package -n libosmoabis6</span><br><span style="color: hsl(120, 100%, 40%);">+%package -n libosmoabis9</span><br><span> Summary: Osmocom GSM A-bis interface library</span><br><span> License: AGPL-3.0-or-later</span><br><span> Group: System/Libraries</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-%description -n libosmoabis6</span><br><span style="color: hsl(120, 100%, 40%);">+%description -n libosmoabis9</span><br><span> In the GSM system architecture, A-bis is a Base Station</span><br><span> System-internal interface linking the Base Transceiver Stations (BTS)</span><br><span> and Base Station Controller (BSC). This interface allows control of</span><br><span>@@ -57,7 +57,7 @@</span><br><span> Summary: Development files for the Osmocom GSM A-bis library</span><br><span> License: AGPL-3.0-or-later</span><br><span> Group: Development/Libraries/C and C++</span><br><span style="color: hsl(0, 100%, 40%);">-Requires: libosmoabis6 = %version</span><br><span style="color: hsl(120, 100%, 40%);">+Requires: libosmoabis9 = %version</span><br><span> Requires: libosmocore-devel >= 0.3.0</span><br><span> Requires: libosmogsm-devel >= 0.3.10</span><br><span> </span><br><span>@@ -119,12 +119,12 @@</span><br><span> %check</span><br><span> make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-%post -n libosmoabis6 -p /sbin/ldconfig</span><br><span style="color: hsl(0, 100%, 40%);">-%postun -n libosmoabis6 -p /sbin/ldconfig</span><br><span style="color: hsl(120, 100%, 40%);">+%post -n libosmoabis9 -p /sbin/ldconfig</span><br><span style="color: hsl(120, 100%, 40%);">+%postun -n libosmoabis9 -p /sbin/ldconfig</span><br><span> %post -n libosmotrau2 -p /sbin/ldconfig</span><br><span> %postun -n libosmotrau2 -p /sbin/ldconfig</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-%files -n libosmoabis6</span><br><span style="color: hsl(120, 100%, 40%);">+%files -n libosmoabis9</span><br><span> %defattr(-,root,root)</span><br><span> %_libdir/libosmoabis.so.6*</span><br><span> </span><br><span>diff --git a/debian/changelog b/debian/changelog</span><br><span>index 68064ca..b839ed9 100644</span><br><span>--- a/debian/changelog</span><br><span>+++ b/debian/changelog</span><br><span>@@ -1,3 +1,80 @@</span><br><span style="color: hsl(120, 100%, 40%);">+libosmo-abis (1.0.0) unstable; urgency=medium</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ [ Neels Hofmeyr ]</span><br><span style="color: hsl(120, 100%, 40%);">+ * add/clean big-endian packed structs (struct_endianess.py)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ [ Harald Welte ]</span><br><span style="color: hsl(120, 100%, 40%);">+ * dahdi: Don't use perror() directly, use osmocom logging instead</span><br><span style="color: hsl(120, 100%, 40%);">+ * introduce and use logging macros with context on E1 line / timeslot</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Use HAVE_E1D in C source, not ENABLE_E1D</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: add missing forward-declaration of e1inp_e1d_init()</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Don't use perror() directly, use osmocom logging instead</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Remove EXCEPTFD handling</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Remove bogus vty_show function.</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Use line->port_nr to specify e1d interface/line</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Use LOGPIL/LOGPITS logging macros to give context</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Don't connect to e1d at program start time</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Implement varions non-LAPD timeslot modes</span><br><span style="color: hsl(120, 100%, 40%);">+ * Add rtp_test to show the double-bind bug of OS#4444</span><br><span style="color: hsl(120, 100%, 40%);">+ * ortp: disable SO_REUSEADDR + SO_REUSEPORT</span><br><span style="color: hsl(120, 100%, 40%);">+ * subchan_demux: Use 'ubit_t' for unpacked bit buffer; use const</span><br><span style="color: hsl(120, 100%, 40%);">+ * trau_frame: use 'ubit_t' for unpacked bits</span><br><span style="color: hsl(120, 100%, 40%);">+ * subchan_demux: Use ubit_t where appropriate</span><br><span style="color: hsl(120, 100%, 40%);">+ * trau_frame.h: Fix definition of TRAU_FT_OM_UP</span><br><span style="color: hsl(120, 100%, 40%);">+ * Fix subchan_demux_test compiler warning on some gcc versions</span><br><span style="color: hsl(120, 100%, 40%);">+ * trau_frame: Fix AMR frame decoding</span><br><span style="color: hsl(120, 100%, 40%);">+ * lapd: Always print context information when logging</span><br><span style="color: hsl(120, 100%, 40%);">+ * fix compilation with --enable-e1d</span><br><span style="color: hsl(120, 100%, 40%);">+ * lapd: Replace magic numbers with #defines</span><br><span style="color: hsl(120, 100%, 40%);">+ * input/lapd.c: Enlarge message buffers for DL-SAP primitives</span><br><span style="color: hsl(120, 100%, 40%);">+ * input/dahdi.c: Don't simply read beyond end of msgb</span><br><span style="color: hsl(120, 100%, 40%);">+ * subchan_demux: Fix out-of-bounds write</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Add new osmo_e1dp_client_ts_open() argument</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Fix compilation after I4a088f91f23aaad05c5ab84a4783c1915d85aca6</span><br><span style="color: hsl(120, 100%, 40%);">+ * contrib/jenkins.sh: Test builds with --enable-e1d</span><br><span style="color: hsl(120, 100%, 40%);">+ * dahdi: Use osmo_revbytebits_buf() instead of local flip table</span><br><span style="color: hsl(120, 100%, 40%);">+ * input/e1d: Fix support for TRAU slots</span><br><span style="color: hsl(120, 100%, 40%);">+ * input/e1d: Add missing "RAW" timeslot support</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1_input_vty: Fix VTY help strings</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ [ Sylvain Munaut ]</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1d: Initial osmo-e1d support</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1_input: Allow to change the pcap fd and/or unset it</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1_input: Add VTY command to enable PCAP debug output</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ [ Oliver Smith ]</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipaccess.c: line_already_initialized: int -> bool</span><br><span style="color: hsl(120, 100%, 40%);">+ * osmo_ortp: add osmo_rtp_socket_set_dscp()</span><br><span style="color: hsl(120, 100%, 40%);">+ * contrib: import RPM spec</span><br><span style="color: hsl(120, 100%, 40%);">+ * contrib: integrate RPM spec</span><br><span style="color: hsl(120, 100%, 40%);">+ * Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in</span><br><span style="color: hsl(120, 100%, 40%);">+ * src/input/ipaccess.c: set TCP_NODELAY</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ [ Eric Wild ]</span><br><span style="color: hsl(120, 100%, 40%);">+ * add ipa ping/pong keepalive for OML/RSL links between bts and bsc</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ [ Eric ]</span><br><span style="color: hsl(120, 100%, 40%);">+ * configure.ac: fix libtool issue with clang and sanitizer</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ [ Pau Espin Pedrol ]</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1_input: refcount inc line during e1_sign_link_create, not during line update</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipaccess.c: Drop repeated ipaccess_keepalive_fsm_cleanup in write error path</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipaccess: Fix log formatting of RESP_ID IPA attributes</span><br><span style="color: hsl(120, 100%, 40%);">+ * cosmetic: e1_input.h: Fix trailing whitespace</span><br><span style="color: hsl(120, 100%, 40%);">+ * e1_input: Use osmo_use_count in e1inp_line</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipaccess: Drop e1inp_line reference in ipacess_drop()</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipacces: Fix e1inp_line reference put in ipaccess_close</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipaccess: Set bfd->data to NULL before releasing its reference</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipaccess_recvmsg: Clean up release steps upon error condition</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipaccess_recvmsg: Assert the new bfd from new line differs from the old one</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipaccess_recvmsg: Untangle code updating line</span><br><span style="color: hsl(120, 100%, 40%);">+ * cosmetic: lapd: Fix trailing whitespace</span><br><span style="color: hsl(120, 100%, 40%);">+ * lapd: Use lapd_dl_init2 instead of deprecated lapd_dl_init</span><br><span style="color: hsl(120, 100%, 40%);">+ * tests: Use API e1inp_line_put2 instead of deprecated e1inp_line_put</span><br><span style="color: hsl(120, 100%, 40%);">+ * ipaccess: Fix use-after-free in ipaccess_drop()</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ -- Harald Welte <laforge@osmocom.org> Thu, 13 Aug 2020 12:09:39 +0200</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> libosmo-abis (0.8.0) unstable; urgency=medium</span><br><span> </span><br><span> [ Alexander Couzens ]</span><br><span>diff --git a/debian/control b/debian/control</span><br><span>index 7039bfe..12f4a4f 100644</span><br><span>--- a/debian/control</span><br><span>+++ b/debian/control</span><br><span>@@ -11,7 +11,7 @@</span><br><span> dh-autoreconf,</span><br><span> libdpkg-perl,</span><br><span> git,</span><br><span style="color: hsl(0, 100%, 40%);">- libosmocore-dev (>= 1.1.0),</span><br><span style="color: hsl(120, 100%, 40%);">+ libosmocore-dev (>= 1.4.0),</span><br><span> pkg-config,</span><br><span> libortp-dev</span><br><span> Standards-Version: 3.9.7</span><br><span>@@ -22,20 +22,16 @@</span><br><span> Package: libosmo-abis</span><br><span> Section: oldlibs</span><br><span> Architecture: any</span><br><span style="color: hsl(0, 100%, 40%);">-Depends: libosmoabis6 (= ${binary:Version}), libosmotrau2 (= ${binary:Version}), ${misc:Depends}</span><br><span style="color: hsl(120, 100%, 40%);">+Depends: libosmoabis9 (= ${binary:Version}), libosmotrau2 (= ${binary:Version}), ${misc:Depends}</span><br><span> Multi-Arch: same</span><br><span> Description: Legacy package for libosmo-abis</span><br><span> libosmo-abis is an empty package helping in the transition to one</span><br><span> package per DSO.</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Package: libosmoabis6</span><br><span style="color: hsl(120, 100%, 40%);">+Package: libosmoabis9</span><br><span> Section: libs</span><br><span> Architecture: any</span><br><span> Multi-Arch: same</span><br><span style="color: hsl(0, 100%, 40%);">-# Due to previous release issues, libosmoabis5 actually installed same libosmoabis.so.6 file.</span><br><span style="color: hsl(0, 100%, 40%);">-# Once major is increased to 7, following two lines below can be dropped:</span><br><span style="color: hsl(0, 100%, 40%);">-Conflicts: libosmoabis5</span><br><span style="color: hsl(0, 100%, 40%);">-Replaces: libosmoabis5</span><br><span> Depends: ${shlibs:Depends},</span><br><span> ${misc:Depends}</span><br><span> Description: GSM A-bis handling</span><br><span>@@ -64,7 +60,7 @@</span><br><span> Section: libdevel</span><br><span> Depends: ${misc:Depends},</span><br><span> libosmotrau2 (= ${binary:Version}),</span><br><span style="color: hsl(0, 100%, 40%);">- libosmoabis6 (= ${binary:Version})</span><br><span style="color: hsl(120, 100%, 40%);">+ libosmoabis9 (= ${binary:Version})</span><br><span> Description: Development headers for A-bis interface</span><br><span> The libosmo-abis library contains common/shared code regarding the A-bis</span><br><span> interface between GSM BTS and BSC. This package in particular contains the</span><br><span>@@ -76,7 +72,7 @@</span><br><span> Multi-Arch: same</span><br><span> Section: debug</span><br><span> Priority: extra</span><br><span style="color: hsl(0, 100%, 40%);">-Depends: libosmoabis6 (= ${binary:Version}),</span><br><span style="color: hsl(120, 100%, 40%);">+Depends: libosmoabis9 (= ${binary:Version}),</span><br><span> libosmotrau2 (= ${binary:Version}),</span><br><span> ${misc:Depends}</span><br><span> Description: Debug symbols for A-bis interface</span><br><span>diff --git a/debian/libosmoabis6.install b/debian/libosmoabis9.install</span><br><span>similarity index 100%</span><br><span>rename from debian/libosmoabis6.install</span><br><span>rename to debian/libosmoabis9.install</span><br><span>diff --git a/src/Makefile.am b/src/Makefile.am</span><br><span>index 3838a5a..1725179 100644</span><br><span>--- a/src/Makefile.am</span><br><span>+++ b/src/Makefile.am</span><br><span>@@ -1,8 +1,8 @@</span><br><span> # This is _NOT_ the library release version, it's an API version.</span><br><span> # Please read chapter "Library interface versions" of the libtool documentation</span><br><span> # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html</span><br><span style="color: hsl(0, 100%, 40%);">-ABIS_LIBVERSION=8:0:2</span><br><span style="color: hsl(0, 100%, 40%);">-TRAU_LIBVERSION=4:0:2</span><br><span style="color: hsl(120, 100%, 40%);">+ABIS_LIBVERSION=9:0:0</span><br><span style="color: hsl(120, 100%, 40%);">+TRAU_LIBVERSION=5:0:3</span><br><span> </span><br><span> AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)</span><br><span> AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOE1D_CFLAGS) $(COVERAGE_CFLAGS)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19618">change 19618</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/19618"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: rel-1.0.0 </div>
<div style="display:none"> Gerrit-Change-Id: Iffbb96739f53c7e005f440bc1615f158f7c661eb </div>
<div style="display:none"> Gerrit-Change-Number: 19618 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>