<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/19584">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sip: Specify invite contact tag<br><br>Version 1.12.12 of libsofia-sip-ua no longer automatically generates a<br>contact header element from the local ip address and port. Specifying<br>the contact tag does not break operation with the existing<br>library (1.12.11), but allows for operation on a system with<br>freeswitch 1.10.4 or later installed, which is built against this new<br>version of libsofia-sip-ua.<br><br>Change-Id: I5c35c5a4bad2fbe76c22ac6d7ee37c832e0ba246<br>---<br>M src/sip.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sip.c b/src/sip.c</span><br><span>index c635542..61916c9 100644</span><br><span>--- a/src/sip.c</span><br><span>+++ b/src/sip.c</span><br><span>@@ -597,6 +597,9 @@</span><br><span>                            called_num,</span><br><span>                          agent->app->sip.remote_addr,</span><br><span>                           agent->app->sip.remote_port);</span><br><span style="color: hsl(120, 100%, 40%);">+   char *contact = talloc_asprintf(leg, "sip:%s:%d",</span><br><span style="color: hsl(120, 100%, 40%);">+                                   agent->app->sip.local_addr,</span><br><span style="color: hsl(120, 100%, 40%);">+                                     agent->app->sip.local_port);</span><br><span>   char *sdp = sdp_create_file(leg, other, sdp_sendrecv);</span><br><span> </span><br><span>   leg->state = SIP_CC_INITIAL;</span><br><span>@@ -604,6 +607,7 @@</span><br><span>        nua_invite(leg->nua_handle,</span><br><span>                       SIPTAG_FROM_STR(from),</span><br><span>                       SIPTAG_TO_STR(to),</span><br><span style="color: hsl(120, 100%, 40%);">+                    SIPTAG_CONTACT_STR(contact),</span><br><span>                         NUTAG_MEDIA_ENABLE(0),</span><br><span>                       SIPTAG_CONTENT_TYPE_STR("application/sdp"),</span><br><span>                        SIPTAG_PAYLOAD_STR(sdp),</span><br><span>@@ -612,6 +616,7 @@</span><br><span>       leg->base.call->remote = &leg->base;</span><br><span>    talloc_free(from);</span><br><span>   talloc_free(to);</span><br><span style="color: hsl(120, 100%, 40%);">+      talloc_free(contact);</span><br><span>        talloc_free(sdp);</span><br><span>    return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/19584">change 19584</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/19584"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5c35c5a4bad2fbe76c22ac6d7ee37c832e0ba246 </div>
<div style="display:none"> Gerrit-Change-Number: 19584 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: matt9j <matt9j@cs.washington.edu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: matt9j <matt9j@cs.washington.edu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>