<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17669">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI<br><br>In [1] I restricted L1 SAPI of PH-RA.ind to PDTCH and PTCCH, and<br>this seems to have caused a regression reported in [2]:<br><br>  DL1IF ERROR sysmo_l1_if.c:251 Rx PH-RA.ind for unknown L1 SAPI PRACH<br><br>I assumed that PH-RA.ind belonging to a Control Acknowledgement<br>message (in format of 4 Access Bursts) would have PDTCH SAPI,<br>while apparently it's actually arriving on PRACH.<br><br>[1] I482d60a46b9d253dfe0b16140eac9fea6420b30c<br>[2] https://osmocom.org/issues/1526#note-39<br><br>Change-Id: Ib0a6da37de7a1db4cad2b96293b31b9f32e7d9eb<br>Related: OS#1526<br>---<br>M src/osmo-bts-litecell15/lc15_l1_if.c<br>M src/osmo-bts-oc2g/oc2g_l1_if.c<br>M src/osmo-bts-sysmo/sysmo_l1_if.c<br>3 files changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-litecell15/lc15_l1_if.c b/src/osmo-bts-litecell15/lc15_l1_if.c</span><br><span>index 0fcd7cf..bf2ecec 100644</span><br><span>--- a/src/osmo-bts-litecell15/lc15_l1_if.c</span><br><span>+++ b/src/osmo-bts-litecell15/lc15_l1_if.c</span><br><span>@@ -250,6 +250,7 @@</span><br><span> </span><br><span>      switch (ra_ind->sapi) {</span><br><span>   case GsmL1_Sapi_Pdtch:</span><br><span style="color: hsl(120, 100%, 40%);">+        case GsmL1_Sapi_Prach:</span><br><span>               bts_update_tbf_ta("PH-RA", ra_ind->u32Fn, fl1h->trx_no, ra_ind->u8Tn,</span><br><span>                               qta2ta(ra_ind->measParam.i16BurstTiming), true);</span><br><span>                break;</span><br><span>diff --git a/src/osmo-bts-oc2g/oc2g_l1_if.c b/src/osmo-bts-oc2g/oc2g_l1_if.c</span><br><span>index 6c1e0f8..0bfe0b9 100644</span><br><span>--- a/src/osmo-bts-oc2g/oc2g_l1_if.c</span><br><span>+++ b/src/osmo-bts-oc2g/oc2g_l1_if.c</span><br><span>@@ -249,6 +249,7 @@</span><br><span> </span><br><span>        switch (ra_ind->sapi) {</span><br><span>   case GsmL1_Sapi_Pdtch:</span><br><span style="color: hsl(120, 100%, 40%);">+        case GsmL1_Sapi_Prach:</span><br><span>               bts_update_tbf_ta("PH-RA", ra_ind->u32Fn, fl1h->trx_no, ra_ind->u8Tn,</span><br><span>                               qta2ta(ra_ind->measParam.i16BurstTiming), true);</span><br><span>                break;</span><br><span>diff --git a/src/osmo-bts-sysmo/sysmo_l1_if.c b/src/osmo-bts-sysmo/sysmo_l1_if.c</span><br><span>index 5e743db..7406bbf 100644</span><br><span>--- a/src/osmo-bts-sysmo/sysmo_l1_if.c</span><br><span>+++ b/src/osmo-bts-sysmo/sysmo_l1_if.c</span><br><span>@@ -239,6 +239,7 @@</span><br><span> </span><br><span>        switch (ra_ind->sapi) {</span><br><span>   case GsmL1_Sapi_Pdtch:</span><br><span style="color: hsl(120, 100%, 40%);">+        case GsmL1_Sapi_Prach:</span><br><span>               bts_update_tbf_ta("PH-RA", ra_ind->u32Fn, fl1h->trx_no, ra_ind->u8Tn,</span><br><span>                               qta2ta(ra_ind->measParam.i16BurstTiming), true);</span><br><span>                break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17669">change 17669</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17669"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib0a6da37de7a1db4cad2b96293b31b9f32e7d9eb </div>
<div style="display:none"> Gerrit-Change-Number: 17669 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>