<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19577">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty/command: reflect command attributes in the XML reference<br><br>Given that commands with either/both of the following attributes:<br><br>  - CMD_ATTR_DEPRECATED,<br>  - CMD_ATTR_HIDDEN,<br><br>would not end up in the XML reference, only CMD_ATTR_REQ_RESTART<br>would be reflected for commands requiring restart as follows:<br><br>  <command id='foo'><br>    <attribute type='restart-required' /><br>    <params><br>      <!-- ... --><br>    </params><br>  </command><br><br>Change-Id: I8476c1163c23a9a52641987acf3df0b8c49d8f7b<br>Related: SYS#4937<br>---<br>M src/vty/command.c<br>1 file changed, 17 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/19577/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index d8fe463..c1ac376 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -622,20 +622,35 @@</span><br><span> </span><br><span> typedef int (*print_func_t)(void *data, const char *fmt, ...);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static const struct value_string cmd_attr_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+        { CMD_ATTR_DEPRECATED,          "deprecated" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { CMD_ATTR_HIDDEN,              "hidden" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { CMD_ATTR_REQ_RESTART,         "restart-required" },</span><br><span style="color: hsl(120, 100%, 40%);">+       { 0, NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*</span><br><span>  * Write one cmd_element as XML via a print_func_t.</span><br><span>  */</span><br><span> static int vty_dump_element(struct cmd_element *cmd, print_func_t print_func, void *data, const char *newline)</span><br><span> {</span><br><span>         char *xml_string = xml_escape(cmd->string);</span><br><span style="color: hsl(120, 100%, 40%);">+        unsigned int i, j;</span><br><span> </span><br><span>       print_func(data, "    <command id='%s'>%s", xml_string, newline);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   /* Optional command attributes */</span><br><span style="color: hsl(120, 100%, 40%);">+     for (i = 0; i < ARRAY_SIZE(cmd_attr_names) - 1; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+             if (~cmd->attr & cmd_attr_names[i].value)</span><br><span style="color: hsl(120, 100%, 40%);">+                      continue;</span><br><span style="color: hsl(120, 100%, 40%);">+             print_func(data, "      <attribute type='%s' />%s",</span><br><span style="color: hsl(120, 100%, 40%);">+                      get_value_string(cmd_attr_names, i), newline);</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  print_func(data, "      <params>%s", newline);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      int j;</span><br><span>       for (j = 0; j < vector_count(cmd->strvec); ++j) {</span><br><span>              vector descvec = vector_slot(cmd->strvec, j);</span><br><span style="color: hsl(0, 100%, 40%);">-                int i;</span><br><span>               for (i = 0; i < vector_active(descvec); ++i) {</span><br><span>                    char *xml_param, *xml_doc;</span><br><span>                   struct desc *desc = vector_slot(descvec, i);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19577">change 19577</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19577"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8476c1163c23a9a52641987acf3df0b8c49d8f7b </div>
<div style="display:none"> Gerrit-Change-Number: 19577 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>