<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_04_08_rr: block EMERGENCY SETUP when EMERGENCY CALLS are denied<br><br>If the BSC configuration is set up to deny emergency calls, make sure<br>that an EMERGENCY SETUP will not be passed to the MSC, instead ensure<br>that the call is released.<br><br>Change-Id: Ia6eb38370ce4165d221d2ffbe1cd105c0628313c<br>Related: OS#4548<br>---<br>M src/osmo-bsc/gsm_04_08_rr.c<br>1 file changed, 19 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>index e54a937..8bf4b2a 100644</span><br><span>--- a/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>+++ b/src/osmo-bsc/gsm_04_08_rr.c</span><br><span>@@ -43,6 +43,7 @@</span><br><span> #include <osmocom/bsc/handover_fsm.h></span><br><span> #include <osmocom/bsc/gsm_08_08.h></span><br><span> #include <osmocom/bsc/gsm_data.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/bsc/bsc_msc_data.h></span><br><span> #include <osmocom/bsc/system_information.h></span><br><span> #include <osmocom/bsc/bts.h></span><br><span> </span><br><span>@@ -988,6 +989,24 @@</span><br><span>                       break;</span><br><span>               }</span><br><span>            break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case GSM48_PDISC_CC:</span><br><span style="color: hsl(120, 100%, 40%);">+          /* Make sure that EMERGENCY CALLS can not be made if the</span><br><span style="color: hsl(120, 100%, 40%);">+               * VTY configuration does not permit. */</span><br><span style="color: hsl(120, 100%, 40%);">+              if (msg_type == GSM48_MT_CC_EMERG_SETUP) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    if (msg->lchan->ts->trx->bts->si_common.rach_control.t2 & 0x4) {</span><br><span style="color: hsl(120, 100%, 40%);">+                           LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP although EMERGENCY CALLS"</span><br><span style="color: hsl(120, 100%, 40%);">+                                          " are not allowed in sysinfo (spec violation by MS!)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                         lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PREMPTIVE_REL);</span><br><span style="color: hsl(120, 100%, 40%);">+                               break;</span><br><span style="color: hsl(120, 100%, 40%);">+                        }</span><br><span style="color: hsl(120, 100%, 40%);">+                     if (!conn->sccp.msc->allow_emerg) {</span><br><span style="color: hsl(120, 100%, 40%);">+                             LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP, but EMERGENCY CALLS are"</span><br><span style="color: hsl(120, 100%, 40%);">+                                          " denied on this BSC (check BTS config!)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                             lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PREMPTIVE_REL);</span><br><span style="color: hsl(120, 100%, 40%);">+                               break;</span><br><span style="color: hsl(120, 100%, 40%);">+                        }</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+             /* fall through */</span><br><span>   default:</span><br><span>             bsc_dtap(conn, link_id, msg);</span><br><span>                break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565">change 19565</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia6eb38370ce4165d221d2ffbe1cd105c0628313c </div>
<div style="display:none"> Gerrit-Change-Number: 19565 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>