<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19561">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MGCP_Test: add E1 related testscases<br><br>osmo-mgw recently added support for E1 trunks via libosmoabis. While the<br>actual E1 plane may be difficult to test, there is some functionality<br>that can already be tested without having E1 support in TTCN3.<br><br>Lets add three testcases:<br>- TC_e1_crcx_and_dlcx_ep:<br> Does a CRCX to an E1 endpoint followed by a DLCX<br>- TC_e1_crcx_with_overlap:<br> Not all E1 endpoint combinations are possible at the same time. This<br> test verifies that invalid endpoint combinations are prevented.<br>- TC_e1_crcx_loopback:<br> Opes an E1 endpoint and tests if RTP loopback works (NO E1 traffic<br> involved)<br><br>Change-Id: I673eeffcb3012b42f039789960c54d99282e1aad<br>Related: OS#2659<br>---<br>M mgw/MGCP_Test.ttcn<br>1 file changed, 87 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn</span><br><span>index 6caef79..24bfdaf 100644</span><br><span>--- a/mgw/MGCP_Test.ttcn</span><br><span>+++ b/mgw/MGCP_Test.ttcn</span><br><span>@@ -2146,6 +2146,88 @@</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Test (valid) CRCX followed by (valid) DLCX containing EP (E1) */</span><br><span style="color: hsl(120, 100%, 40%);">+ testcase TC_e1_crcx_and_dlcx_ep() runs on dummy_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var template MgcpCommand cmd;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpResponse resp;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpEndpoint ep := "ds/e1-1/s-1/su16-0@" & c_mgw_domain;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpCallId call_id := '8376F297'H;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(ep);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ resp := mgcp_transceive_mgw(cmd, tr_CRCX_ACK);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_dlcx_ok(ep);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Test what happens when overlapping endpoints are selected (E1) */</span><br><span style="color: hsl(120, 100%, 40%);">+ testcase TC_e1_crcx_with_overlap() runs on dummy_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var template MgcpCommand cmd;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpResponse resp;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpEndpoint ep_1 := "ds/e1-1/s-1/su8-0@" & c_mgw_domain;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpEndpoint ep_2 := "ds/e1-1/s-1/su16-0@" & c_mgw_domain;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpCallId call_id_1 := '8376F297'H;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpCallId call_id_2 := '837AF2A7'H;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* ep_1 and ep_2 are overlapping, selecting both one after</span><br><span style="color: hsl(120, 100%, 40%);">+ * another should work fine: */</span><br><span style="color: hsl(120, 100%, 40%);">+ cmd := ts_CRCX(get_next_trans_id(), ep_1, "recvonly", call_id_1);</span><br><span style="color: hsl(120, 100%, 40%);">+ resp := mgcp_transceive_mgw(cmd, tr_CRCX_ACK);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_dlcx_ok(ep_1);</span><br><span style="color: hsl(120, 100%, 40%);">+ cmd := ts_CRCX(get_next_trans_id(), ep_2, "recvonly", call_id_2);</span><br><span style="color: hsl(120, 100%, 40%);">+ resp := mgcp_transceive_mgw(cmd, tr_CRCX_ACK);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_dlcx_ok(ep_2);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* When ep_1 is serving a call we can not select ep_2 becaus</span><br><span style="color: hsl(120, 100%, 40%);">+ * it is overlapping with ep_1 */</span><br><span style="color: hsl(120, 100%, 40%);">+ cmd := ts_CRCX(get_next_trans_id(), ep_1, "recvonly", call_id_1);</span><br><span style="color: hsl(120, 100%, 40%);">+ resp := mgcp_transceive_mgw(cmd, tr_CRCX_ACK);</span><br><span style="color: hsl(120, 100%, 40%);">+ cmd := ts_CRCX(get_next_trans_id(), ep_2, "recvonly", call_id_2);</span><br><span style="color: hsl(120, 100%, 40%);">+ resp := mgcp_transceive_mgw(cmd, ?);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (resp.line.code != "501") {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "unexpected CRCX returncode, CRCX should fail!");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ f_dlcx_ok(ep_1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Create one connection in loopback mode, test if the RTP packets are</span><br><span style="color: hsl(120, 100%, 40%);">+ * actually reflected */</span><br><span style="color: hsl(120, 100%, 40%);">+ testcase TC_e1_crcx_loopback() runs on dummy_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var RtpFlowData flow;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpEndpoint ep := "ds/e1-1/s-1/su16-0@" & c_mgw_domain;</span><br><span style="color: hsl(120, 100%, 40%);">+ var MgcpCallId call_id := '12250989'H;</span><br><span style="color: hsl(120, 100%, 40%);">+ var RtpemStats stats;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(ep);</span><br><span style="color: hsl(120, 100%, 40%);">+ flow := valueof(t_RtpFlow(mp_local_ip, mp_remote_ip, 111, "GSM-HR-08/8000/1"));</span><br><span style="color: hsl(120, 100%, 40%);">+ flow.em.portnr := 10000;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_flow_create(RTPEM[0], ep, call_id, "loopback", flow);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_mode(RTPEM[0], RTPEM_MODE_BIDIR);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_flow_delete(RTPEM[0], ep, call_id);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ stats := f_rtpem_stats_get(RTPEM[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (stats.num_pkts_tx != stats.num_pkts_rx) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (stats.bytes_payload_tx != stats.bytes_payload_rx) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_stats_err_check(stats);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> control {</span><br><span> execute(TC_selftest());</span><br><span> execute(TC_crcx());</span><br><span>@@ -2201,5 +2283,10 @@</span><br><span> execute(TC_amr_bwe_bwe_rtp_conversion());</span><br><span> </span><br><span> execute(TC_conn_timeout());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ execute(TC_e1_crcx_and_dlcx_ep());</span><br><span style="color: hsl(120, 100%, 40%);">+ execute(TC_e1_crcx_with_overlap());</span><br><span style="color: hsl(120, 100%, 40%);">+ execute(TC_e1_crcx_loopback());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19561">change 19561</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19561"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I673eeffcb3012b42f039789960c54d99282e1aad </div>
<div style="display:none"> Gerrit-Change-Number: 19561 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>