<p style="white-space: pre-wrap; word-wrap: break-word;">Mostly cosmetic comments.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565/1/src/osmo-bsc/gsm_04_08_rr.c">File src/osmo-bsc/gsm_04_08_rr.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565/1/src/osmo-bsc/gsm_04_08_rr.c@995">Patch Set #1, Line 995:</a> <code style="font-family:monospace,monospace">if(</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">coding style</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565/1/src/osmo-bsc/gsm_04_08_rr.c@997">Patch Set #1, Line 997:</a> <code style="font-family:monospace,monospace">LOG_LCHAN</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This log statement seems to be longer than 120 chars, would be nice to split it.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565/1/src/osmo-bsc/gsm_04_08_rr.c@1002">Patch Set #1, Line 1002:</a> <code style="font-family:monospace,monospace">                                LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP, but EMERGENCY CALLS are denied on this BSC (check BTS config!)\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565">change 19565</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19565"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia6eb38370ce4165d221d2ffbe1cd105c0628313c </div>
<div style="display:none"> Gerrit-Change-Number: 19565 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 12 Aug 2020 10:36:59 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>