<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19559">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hodec2: do not keep candidates with zero requirements met<br><br>When check_requirements() returns zero, do not keep such an entry in the<br>candidates list at all. This removes logging confusion, where some "candidates"<br>are still listed even though not meeting any handover requirements.<br><br>Change-Id: I12e48292d5731cb601165c870b9570003bc488ec<br>---<br>M src/osmo-bsc/handover_decision_2.c<br>1 file changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/59/19559/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c</span><br><span>index 26a8840..3191957 100644</span><br><span>--- a/src/osmo-bsc/handover_decision_2.c</span><br><span>+++ b/src/osmo-bsc/handover_decision_2.c</span><br><span>@@ -861,6 +861,10 @@</span><br><span>       };</span><br><span> </span><br><span>       debug_candidate(&c, 0, tchf_count, tchh_count);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!c.requirements)</span><br><span style="color: hsl(120, 100%, 40%);">+          return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    clist[*candidates] = c;</span><br><span>      (*candidates)++;</span><br><span> }</span><br><span>@@ -966,6 +970,9 @@</span><br><span> </span><br><span>      debug_candidate(&c, av_rxlev, tchf_count, tchh_count);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        if (!c.requirements)</span><br><span style="color: hsl(120, 100%, 40%);">+          return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    clist[*candidates] = c;</span><br><span>      (*candidates)++;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19559">change 19559</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19559"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I12e48292d5731cb601165c870b9570003bc488ec </div>
<div style="display:none"> Gerrit-Change-Number: 19559 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>