<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19558">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hodec2 congestion: consider only congested pchan types<br><br>If no TCH/H need to be moved, then don't collect TCH/H candidates.<br>Same for TCH/F.<br><br>Examining a specific congestion scenario, I realized that ho decision 2<br>collects candidates of pchan types that are not actually considered congested:<br><br>- handover decision 2 wants to move 2 TCH/F only; TCH/H is fine.<br>- still it collects active TCH/H lchans as candidates.<br><br>  (BTS 0) Congestion check: (free/want-free) TCH/F=0/2 TCH/H=12/0<br>  (BTS 0) Attempting to resolve congestion...<br>  (BTS 0) congested: 2 TCH/F and 0 TCH/H should be moved<br>  [...]<br>  (BTS 0) Considering 8 candidates to solve congestion:<br>  (lchan 0.020 TCH_F SPEECH_V1)->(BTS 0) (subscr unknown) #0: req=0x0 avg-rxlev=42<br>  (lchan 0.030 TCH_F SPEECH_V1)->(BTS 0) (subscr unknown) #1: req=0x0 avg-rxlev=42<br>  (lchan 0.040 TCH_F SPEECH_V1)->(BTS 0) (subscr unknown) #2: req=0x0 avg-rxlev=42<br>  (lchan 0.050 TCH_F SPEECH_V1)->(BTS 0) (subscr unknown) #3: req=0x0 avg-rxlev=42<br>  (lchan 0.160 TCH_H SPEECH_V1)->(BTS 0) (subscr IMSI:9017000000xxxxx) #4: req=0x0 avg-rxlev=42<br>  (lchan 0.161 TCH_H SPEECH_V1)->(BTS 0) (subscr IMSI:9017000000xxxxx) #5: req=0x0 avg-rxlev=42<br>  (lchan 0.170 TCH_H SPEECH_V1)->(BTS 0) (subscr IMSI:9017000000xxxxx) #6: req=0x0 avg-rxlev=42<br>  (lchan 0.171 TCH_H SPEECH_V1)->(BTS 0) (subscr IMSI:9017000000xxxxx) #7: req=0x0 avg-rxlev=42<br><br>Change-Id: I5077a62c6d77838513eecf3f0e4810c3d3d3a247<br>---<br>M src/osmo-bsc/handover_decision_2.c<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/19558/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c</span><br><span>index 4c32c38..26a8840 100644</span><br><span>--- a/src/osmo-bsc/handover_decision_2.c</span><br><span>+++ b/src/osmo-bsc/handover_decision_2.c</span><br><span>@@ -1445,6 +1445,10 @@</span><br><span>                      /* (Do not consider dynamic TS that are in PDCH mode) */</span><br><span>                     switch (ts->pchan_is) {</span><br><span>                   case GSM_PCHAN_TCH_F:</span><br><span style="color: hsl(120, 100%, 40%);">+                         /* No need to collect TCH/F candidates if no TCH/F needs to be moved. */</span><br><span style="color: hsl(120, 100%, 40%);">+                              if (tchf_congestion == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                                     continue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                          lc = &ts->lchan[0];</span><br><span>                           /* omit if channel not active */</span><br><span>                             if (lc->type != GSM_LCHAN_TCH_F</span><br><span>@@ -1459,6 +1463,10 @@</span><br><span>                          collect_candidates_for_lchan(lc, clist, &candidates, NULL, true);</span><br><span>                                break;</span><br><span>                       case GSM_PCHAN_TCH_H:</span><br><span style="color: hsl(120, 100%, 40%);">+                         /* No need to collect TCH/H candidates if no TCH/H needs to be moved. */</span><br><span style="color: hsl(120, 100%, 40%);">+                              if (tchh_congestion == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                                     continue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                          for (j = 0; j < 2; j++) {</span><br><span>                                         lc = &ts->lchan[j];</span><br><span>                                   /* omit if channel not active */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19558">change 19558</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19558"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5077a62c6d77838513eecf3f0e4810c3d3d3a247 </div>
<div style="display:none"> Gerrit-Change-Number: 19558 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>