<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19553">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: allow enabling freq. hopping regardless of the feature vector<br><br>The hard-coded per-BTS feature vector for osmo-bts currently lacks<br>BTS_FEAT_HOPPING, and this is unlikely to change, because only the<br>recent osmo-bts-trx does support freq. hopping, while the other<br>(DSP based) back-ends do not seem to be capable of doing it.<br><br>Let's allow enabling freq. hopping regardless of the feature vector,<br>so either it would work if it's supported, or the BTS would reject<br>Set Channel Attributes message by sending NACK on the A-bis/OML.<br><br>Change-Id: Iff23109cacb5d314f7bcbf34b25e89af9281ce40<br>Related: SYS#4868, OS#4546<br>---<br>M src/osmo-bsc/bsc_vty.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/53/19553/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 16935d3..9bb650f 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -4588,9 +4588,10 @@</span><br><span>       int enabled = atoi(argv[0]);</span><br><span> </span><br><span>     if (enabled && !osmo_bts_has_feature(&ts->trx->bts->model->features, BTS_FEAT_HOPPING)) {</span><br><span style="color: hsl(0, 100%, 40%);">-               vty_out(vty, "%% BTS model does not support hopping%s",</span><br><span style="color: hsl(0, 100%, 40%);">-                       VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-           return CMD_WARNING;</span><br><span style="color: hsl(120, 100%, 40%);">+           vty_out(vty, "%% BTS model does not seem to support freq. hopping%s", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+         /* Allow enabling frequency hopping anyway, because the BTS might not have</span><br><span style="color: hsl(120, 100%, 40%);">+             * connected yet (thus not sent the feature vector), so we cannot know for</span><br><span style="color: hsl(120, 100%, 40%);">+             * sure.  Jet print a warning and let it go. */</span><br><span>      }</span><br><span> </span><br><span>        ts->hopping.enabled = enabled;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19553">change 19553</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19553"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iff23109cacb5d314f7bcbf34b25e89af9281ce40 </div>
<div style="display:none"> Gerrit-Change-Number: 19553 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>