<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/19509">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu_sock: use a 'switch' statement in ts_should_be_pdch()<br><br>Change-Id: I628c2c5198c52fb82309dfe4a31a59aeebc00f09<br>---<br>M src/common/pcu_sock.c<br>1 file changed, 6 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c</span><br><span>index 8966b31..0125793 100644</span><br><span>--- a/src/common/pcu_sock.c</span><br><span>+++ b/src/common/pcu_sock.c</span><br><span>@@ -86,9 +86,10 @@</span><br><span> </span><br><span> static bool ts_should_be_pdch(const struct gsm_bts_trx_ts *ts)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- if (ts->pchan == GSM_PCHAN_PDCH)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (ts->pchan) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case GSM_PCHAN_PDCH:</span><br><span> return true;</span><br><span style="color: hsl(0, 100%, 40%);">- if (ts->pchan == GSM_PCHAN_TCH_F_PDCH) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case GSM_PCHAN_TCH_F_PDCH:</span><br><span> /* When we're busy deactivating the PDCH, we first set</span><br><span> * DEACT_PENDING, tell the PCU about it and wait for a</span><br><span> * response. So DEACT_PENDING means "no PDCH" to the PCU.</span><br><span>@@ -99,16 +100,16 @@</span><br><span> return !(ts->flags & TS_F_PDCH_DEACT_PENDING);</span><br><span> else</span><br><span> return (ts->flags & TS_F_PDCH_ACT_PENDING);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- if (ts->pchan == GSM_PCHAN_TCH_F_TCH_H_PDCH) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case GSM_PCHAN_TCH_F_TCH_H_PDCH:</span><br><span> /*</span><br><span> * When we're busy de-/activating the PDCH, we first set</span><br><span> * ts->dyn.pchan_want, tell the PCU about it and wait for a</span><br><span> * response. So only care about dyn.pchan_want here.</span><br><span> */</span><br><span> return ts->dyn.pchan_want == GSM_PCHAN_PDCH;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ return false;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- return false;</span><br><span> }</span><br><span> </span><br><span> int pcu_tx_info_ind(void)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/19509">change 19509</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/19509"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I628c2c5198c52fb82309dfe4a31a59aeebc00f09 </div>
<div style="display:none"> Gerrit-Change-Number: 19509 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>