<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19538">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trau_frame: Fix computation of odd parity while encoding HR frames<br><br>division modulo 1 is always 0, and hence we always returned '1'<br>as parity bit.  Instead, we need to check if the LSB is set in order to<br>know if the number of bits is odd or even.<br><br>Change-Id: I37af702ba020a90a820bae84cb603e187ebbacb5<br>Closes: CID#211594<br>---<br>M src/trau/trau_frame.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c</span><br><span>index 0a8faf9..1159bb1 100644</span><br><span>--- a/src/trau/trau_frame.c</span><br><span>+++ b/src/trau/trau_frame.c</span><br><span>@@ -817,7 +817,7 @@</span><br><span>                  sum++;</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (sum % 1)</span><br><span style="color: hsl(120, 100%, 40%);">+  if (sum & 1)</span><br><span>             return 0;</span><br><span>    else</span><br><span>                 return 1;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19538">change 19538</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/19538"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I37af702ba020a90a820bae84cb603e187ebbacb5 </div>
<div style="display:none"> Gerrit-Change-Number: 19538 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>