<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19521">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add missing build dependency to libosmocodec-dev<br><br>Since I0190872dd282bcfe0f97bb4f8ab8d09023f9f06b we are using a header<br>file provided by libosmocodec, which means we need to add it to our<br>dependencies (and include path).  Linking against the library is<br>not required, as we don't use any symbols at this point.<br><br>Change-Id: Ie4524165d8873f6c801e07d9f03c94f43c66110d<br>---<br>M configure.ac<br>M contrib/libosmo-abis.spec.in<br>M src/Makefile.am<br>3 files changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/configure.ac b/configure.ac</span><br><span>index 04ffca6..d24010e 100644</span><br><span>--- a/configure.ac</span><br><span>+++ b/configure.ac</span><br><span>@@ -67,6 +67,7 @@</span><br><span> PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.1.0)</span><br><span> PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.1.0)</span><br><span> PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.1.0)</span><br><span style="color: hsl(120, 100%, 40%);">+PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.1.0)</span><br><span> PKG_CHECK_MODULES(ORTP, ortp >= 0.22.0)</span><br><span> </span><br><span> AC_ARG_ENABLE([dahdi],</span><br><span>diff --git a/contrib/libosmo-abis.spec.in b/contrib/libosmo-abis.spec.in</span><br><span>index da0c2d8..abde676 100644</span><br><span>--- a/contrib/libosmo-abis.spec.in</span><br><span>+++ b/contrib/libosmo-abis.spec.in</span><br><span>@@ -30,6 +30,7 @@</span><br><span> BuildRequires:  pkgconfig(libosmocore) >= 1.1.0</span><br><span> BuildRequires:  pkgconfig(libosmogsm) >= 1.1.0</span><br><span> BuildRequires:  pkgconfig(libosmovty) >= 1.1.0</span><br><span style="color: hsl(120, 100%, 40%);">+BuildRequires:  pkgconfig(libosmocodec) >= 1.1.0</span><br><span> BuildRequires:  pkgconfig(ortp) >= 0.22</span><br><span> BuildRequires:  pkgconfig(talloc)</span><br><span> </span><br><span>diff --git a/src/Makefile.am b/src/Makefile.am</span><br><span>index 4254428..f5dd865 100644</span><br><span>--- a/src/Makefile.am</span><br><span>+++ b/src/Makefile.am</span><br><span>@@ -5,9 +5,9 @@</span><br><span> TRAU_LIBVERSION=4:0:2</span><br><span> </span><br><span> AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)</span><br><span style="color: hsl(0, 100%, 40%);">-AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOE1D_CFLAGS) $(COVERAGE_CFLAGS)</span><br><span style="color: hsl(120, 100%, 40%);">+AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOE1D_CFLAGS) $(LIBOSMOCODEC_CFLAGS) $(COVERAGE_CFLAGS)</span><br><span> AM_LDFLAGS = $(COVERAGE_LDFLAGS)</span><br><span style="color: hsl(0, 100%, 40%);">-COMMONLIBS = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMOE1D_LIBS)</span><br><span style="color: hsl(120, 100%, 40%);">+COMMONLIBS = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMOE1D_LIBS) # libosmocodec not [yet] needed here</span><br><span> </span><br><span> lib_LTLIBRARIES = libosmoabis.la libosmotrau.la</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19521">change 19521</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/19521"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie4524165d8873f6c801e07d9f03c94f43c66110d </div>
<div style="display:none"> Gerrit-Change-Number: 19521 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>