<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19456">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests: vty: Extend test to do some numeric range validations<br><br>As per current status, the numeric tests are expected to fail due to a<br>couple bugs which will be fixed in next commits.<br><br>Change-Id: Id5b17bd96d7af4ed9a77ebbea0e6be4b0fcbde6c<br>---<br>M tests/vty/vty_test.c<br>M tests/vty/vty_test.ok<br>2 files changed, 40 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/19456/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/vty/vty_test.c b/tests/vty/vty_test.c</span><br><span>index 9627b6d..7146a1d 100644</span><br><span>--- a/tests/vty/vty_test.c</span><br><span>+++ b/tests/vty/vty_test.c</span><br><span>@@ -22,6 +22,7 @@</span><br><span> #include <stdio.h></span><br><span> #include <string.h></span><br><span> #include <errno.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <limits.h></span><br><span> </span><br><span> #include <sys/types.h></span><br><span> #include <sys/socket.h></span><br><span>@@ -438,6 +439,19 @@</span><br><span> return CMD_WARNING;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_numeric_range, cfg_numeric_range_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+#if ULONG_MAX == 18446744073709551615UL</span><br><span style="color: hsl(120, 100%, 40%);">+ "numeric-range <0-18446744073709551615>",</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+ "numeric-range <0-4294967295>",</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+ "testing numeric range\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "the numeric range\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("Called: 'return-success'\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> void test_vty_add_cmds()</span><br><span> {</span><br><span> install_element(CONFIG_NODE, &cfg_ret_warning_cmd);</span><br><span>@@ -461,6 +475,8 @@</span><br><span> install_element_ve(&cfg_ambiguous_nr_2_cmd);</span><br><span> install_element_ve(&cfg_ambiguous_str_1_cmd);</span><br><span> install_element_ve(&cfg_ambiguous_str_2_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element_ve(&cfg_numeric_range_cmd);</span><br><span> }</span><br><span> </span><br><span> void test_is_cmd_ambiguous()</span><br><span>@@ -482,6 +498,21 @@</span><br><span> destroy_test_vty(&test, vty);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void test_numeric_range()</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct vty *vty;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct vty_test test;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("Going to test test_numeric_range()\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ vty = create_test_vty(&test);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(do_vty_command(vty, "numeric-range 0") == CMD_ERR_NO_MATCH);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(do_vty_command(vty, "numeric-range 40000") == CMD_ERR_NO_MATCH);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(do_vty_command(vty, "numeric-range -400000") == CMD_ERR_NO_MATCH);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ destroy_test_vty(&test, vty);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> int main(int argc, char **argv)</span><br><span> {</span><br><span> struct vty_app_info vty_info = {</span><br><span>@@ -535,6 +566,8 @@</span><br><span> </span><br><span> test_is_cmd_ambiguous();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ test_numeric_range();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Leak check */</span><br><span> OSMO_ASSERT(talloc_total_blocks(stats_ctx) == 1);</span><br><span> </span><br><span>diff --git a/tests/vty/vty_test.ok b/tests/vty/vty_test.ok</span><br><span>index d2c9611..d81c6c7 100644</span><br><span>--- a/tests/vty/vty_test.ok</span><br><span>+++ b/tests/vty/vty_test.ok</span><br><span>@@ -311,4 +311,11 @@</span><br><span> Going to execute 'ambiguous_str arg keyword'</span><br><span> Called: 'ambiguous_str ARG keyword'</span><br><span> Returned: 0, Current node: 1 '%s> '</span><br><span style="color: hsl(120, 100%, 40%);">+Going to test test_numeric_range()</span><br><span style="color: hsl(120, 100%, 40%);">+Going to execute 'numeric-range 0'</span><br><span style="color: hsl(120, 100%, 40%);">+Returned: 2, Current node: 1 '%s> '</span><br><span style="color: hsl(120, 100%, 40%);">+Going to execute 'numeric-range 40000'</span><br><span style="color: hsl(120, 100%, 40%);">+Returned: 2, Current node: 1 '%s> '</span><br><span style="color: hsl(120, 100%, 40%);">+Going to execute 'numeric-range -400000'</span><br><span style="color: hsl(120, 100%, 40%);">+Returned: 2, Current node: 1 '%s> '</span><br><span> All tests passed</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19456">change 19456</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19456"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id5b17bd96d7af4ed9a77ebbea0e6be4b0fcbde6c </div>
<div style="display:none"> Gerrit-Change-Number: 19456 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>