<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19424">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  Hoernchen: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Don't match negative values on purely positive ranges<br><br>Without this patch, for instance having a range 0-ULONG_MAX would match<br>if someones types value -3, which would be converted to unsigned but<br>that's clearly what is expected here from user point of view.<br><br>Change-Id: Ia95f6314a2dd3f94d21fc219cf69bb8d39b8e7f0<br>---<br>M src/vty/command.c<br>M tests/vty/vty_test.c<br>M tests/vty/vty_test.ok<br>3 files changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index 16dd07f..278ceb5 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -1325,6 +1325,9 @@</span><br><span>    } else {</span><br><span>             unsigned long min, max, val;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+              if (str[0] == '-')</span><br><span style="color: hsl(120, 100%, 40%);">+                    return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          val = strtoul(str, &endptr, 10);</span><br><span>                 if (*endptr != '\0')</span><br><span>                         return 0;</span><br><span>diff --git a/tests/vty/vty_test.c b/tests/vty/vty_test.c</span><br><span>index a7aef11..b2d34ad 100644</span><br><span>--- a/tests/vty/vty_test.c</span><br><span>+++ b/tests/vty/vty_test.c</span><br><span>@@ -508,7 +508,7 @@</span><br><span> </span><br><span>     OSMO_ASSERT(do_vty_command(vty, "numeric-range 0") == CMD_SUCCESS);</span><br><span>        OSMO_ASSERT(do_vty_command(vty, "numeric-range 40000") == CMD_SUCCESS);</span><br><span style="color: hsl(0, 100%, 40%);">-       OSMO_ASSERT(do_vty_command(vty, "numeric-range -400000") == CMD_SUCCESS);</span><br><span style="color: hsl(120, 100%, 40%);">+   OSMO_ASSERT(do_vty_command(vty, "numeric-range -400000") == CMD_ERR_NO_MATCH);</span><br><span> </span><br><span>         destroy_test_vty(&test, vty);</span><br><span> }</span><br><span>diff --git a/tests/vty/vty_test.ok b/tests/vty/vty_test.ok</span><br><span>index bac083d..5f509f6 100644</span><br><span>--- a/tests/vty/vty_test.ok</span><br><span>+++ b/tests/vty/vty_test.ok</span><br><span>@@ -319,6 +319,5 @@</span><br><span> Called: 'return-success'</span><br><span> Returned: 0, Current node: 1 '%s> '</span><br><span> Going to execute 'numeric-range -400000'</span><br><span style="color: hsl(0, 100%, 40%);">-Called: 'return-success'</span><br><span style="color: hsl(0, 100%, 40%);">-Returned: 0, Current node: 1 '%s> '</span><br><span style="color: hsl(120, 100%, 40%);">+Returned: 2, Current node: 1 '%s> '</span><br><span> All tests passed</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19424">change 19424</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19424"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia95f6314a2dd3f94d21fc219cf69bb8d39b8e7f0 </div>
<div style="display:none"> Gerrit-Change-Number: 19424 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>