<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19463">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">log stderr: Increase output buffering using setvbuf()<br><br>Change-Id: I59beadb8d1d10a942513efc4c0477701f967237a<br>---<br>M src/logging.c<br>1 file changed, 15 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/19463/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/logging.c b/src/logging.c</span><br><span>index c14e696..683db97 100644</span><br><span>--- a/src/logging.c</span><br><span>+++ b/src/logging.c</span><br><span>@@ -903,6 +903,7 @@</span><br><span> struct log_target *log_target_create_file(const char *fname)</span><br><span> {</span><br><span>   struct log_target *target;</span><br><span style="color: hsl(120, 100%, 40%);">+    int rc;</span><br><span> </span><br><span>  target = log_target_create();</span><br><span>        if (!target)</span><br><span>@@ -913,6 +914,12 @@</span><br><span>  if (!target->tgt_file.out)</span><br><span>                return NULL;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      rc = setvbuf(target->tgt_file.out, NULL, _IOFBF, 128*1024);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (rc != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DLGLOBAL, LOGL_NOTICE, "Could not increase output buffer size for '%s': %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+              fname, strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  target->output = _file_output;</span><br><span> </span><br><span>        target->tgt_file.fname = talloc_strdup(target, fname);</span><br><span>@@ -980,12 +987,20 @@</span><br><span>  *  \returns 0 in case of success; negative otherwise */</span><br><span> int log_target_file_reopen(struct log_target *target)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+   int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    fclose(target->tgt_file.out);</span><br><span> </span><br><span>         target->tgt_file.out = fopen(target->tgt_file.fname, "a");</span><br><span>   if (!target->tgt_file.out)</span><br><span>                return -errno;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    rc = setvbuf(target->tgt_file.out, NULL, _IOFBF, 128*1024);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (rc != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DLGLOBAL, LOGL_NOTICE, "Could not increase output buffer size for '%s': %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+              target->tgt_file.fname, strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* we assume target->output already to be set */</span><br><span> </span><br><span>      return 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19463">change 19463</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19463"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I59beadb8d1d10a942513efc4c0477701f967237a </div>
<div style="display:none"> Gerrit-Change-Number: 19463 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>