<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19447">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SCOC: log message type that was received for unknown local reference<br><br>A message like<br>DLSCCP <0011> sccp_scoc.c:1653 Cannot find connection for local reference 1154<br>is not incredibly useful, as you don't even know what type of SCCP/SUA<br>message had been received.<br><br>Change-Id: I18af9d7e9ea4877b13bf98a980b0ba97c5ed6599<br>---<br>M src/sccp_scoc.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c</span><br><span>index 015850e..1ce08f8 100644</span><br><span>--- a/src/sccp_scoc.c</span><br><span>+++ b/src/sccp_scoc.c</span><br><span>@@ -1649,8 +1649,8 @@</span><br><span> conn_id = xua_msg_get_u32(xua, SUA_IEI_DEST_REF);</span><br><span> conn = conn_find_by_id(inst, conn_id);</span><br><span> if (!conn) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DLSCCP, LOGL_NOTICE, "Cannot find connection for "</span><br><span style="color: hsl(0, 100%, 40%);">- "local reference %u\n", conn_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DLSCCP, LOGL_NOTICE, "Received %s: Cannot find connection for "</span><br><span style="color: hsl(120, 100%, 40%);">+ "local reference %u\n", xua_hdr_dump(xua, &xua_dialect_sua), conn_id);</span><br><span> sccp_scoc_rx_unass_local_ref(inst, xua);</span><br><span> return;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19447">change 19447</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/19447"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I18af9d7e9ea4877b13bf98a980b0ba97c5ed6599 </div>
<div style="display:none"> Gerrit-Change-Number: 19447 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>