<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19423">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Allow larger strlen parsing numerical range values<br><br>This allows for instance accepting a range:<br><0x00-0xffffffffffffffff>, which is a 64bit mask.<br><br>Change-Id: Id053acd6bf5e8fb7c468959f0b78b778f8c5e6c2<br>---<br>M src/vty/command.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/19423/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index 256f1db..cc52c14 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -1262,12 +1262,12 @@</span><br><span> </span><br><span> #endif                             /* HAVE_IPV6  */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define DECIMAL_STRLEN_MAX 10</span><br><span style="color: hsl(120, 100%, 40%);">+#define NUMERIC_STRLEN_MAX 18</span><br><span> </span><br><span> static int cmd_range_match(const char *range, const char *str)</span><br><span> {</span><br><span>  char *p;</span><br><span style="color: hsl(0, 100%, 40%);">-        char buf[DECIMAL_STRLEN_MAX + 1];</span><br><span style="color: hsl(120, 100%, 40%);">+     char buf[NUMERIC_STRLEN_MAX + 1];</span><br><span>    char *endptr = NULL;</span><br><span> </span><br><span>     if (str == NULL)</span><br><span>@@ -1284,7 +1284,7 @@</span><br><span>             p = strchr(range, '-');</span><br><span>              if (p == NULL)</span><br><span>                       return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-               if (p - range > DECIMAL_STRLEN_MAX)</span><br><span style="color: hsl(120, 100%, 40%);">+                if (p - range > NUMERIC_STRLEN_MAX)</span><br><span>                       return 0;</span><br><span>            strncpy(buf, range, p - range);</span><br><span>              buf[p - range] = '\0';</span><br><span>@@ -1296,7 +1296,7 @@</span><br><span>               p = strchr(range, '>');</span><br><span>           if (p == NULL)</span><br><span>                       return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-               if (p - range > DECIMAL_STRLEN_MAX)</span><br><span style="color: hsl(120, 100%, 40%);">+                if (p - range > NUMERIC_STRLEN_MAX)</span><br><span>                       return 0;</span><br><span>            strncpy(buf, range, p - range);</span><br><span>              buf[p - range] = '\0';</span><br><span>@@ -1317,7 +1317,7 @@</span><br><span>               p = strchr(range, '-');</span><br><span>              if (p == NULL)</span><br><span>                       return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-               if (p - range > DECIMAL_STRLEN_MAX)</span><br><span style="color: hsl(120, 100%, 40%);">+                if (p - range > NUMERIC_STRLEN_MAX)</span><br><span>                       return 0;</span><br><span>            strncpy(buf, range, p - range);</span><br><span>              buf[p - range] = '\0';</span><br><span>@@ -1329,7 +1329,7 @@</span><br><span>               p = strchr(range, '>');</span><br><span>           if (p == NULL)</span><br><span>                       return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-               if (p - range > DECIMAL_STRLEN_MAX)</span><br><span style="color: hsl(120, 100%, 40%);">+                if (p - range > NUMERIC_STRLEN_MAX)</span><br><span>                       return 0;</span><br><span>            strncpy(buf, range, p - range);</span><br><span>              buf[p - range] = '\0';</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19423">change 19423</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19423"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id053acd6bf5e8fb7c468959f0b78b778f8c5e6c2 </div>
<div style="display:none"> Gerrit-Change-Number: 19423 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>