<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19146">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h">File include/osmocom/gsm/protocol/gsm_12_21.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h@428">Patch Set #2, Line 428:</a> <code style="font-family:monospace,monospace">  NM_ATT_IPACC_PAGING_CFG         = 0x8f,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NM_ATT_IPACC_PAGING_CFG  = NM_ATT_BS11_RF_RES_IND_PER</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h@464">Patch Set #2, Line 464:</a> <code style="font-family:monospace,monospace">  NM_ATT_BS11_RF_RES_IND_PER      = 0x8f,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NM_ATT_IPACC_PAGING_CFG  = NM_ATT_BS11_RF_RES_IND_PER</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/19146/2/include/osmocom/gsm/protocol/gsm_12_21.h@514">Patch Set #2, Line 514:</a> <code style="font-family:monospace,monospace">, /*</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">not sure if it is legal to have two enum members map to the same value (NM_ATT_BS11_PASSWORD just a  […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">we're doing it already with 0x8f.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19146">change 19146</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19146"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 </div>
<div style="display:none"> Gerrit-Change-Number: 19146 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 28 Jul 2020 09:32:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>