<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19389">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lchan_fsm: silently ignore LCHAN_EV_RLL_ERR_IND<br><br>The RLL ERR IND is sent by the BTS in any number of casese that lead<br>to a disconnect of a radio link layer, for example due to bad RF<br>conditions.  The lchan FSM currnently prints error messages about<br>this event not being permitted, leading to confusion among users.<br><br>Let's ignore this event, I don't think the lchan FSM should or could<br>be doing anything as a result.  We could also simply remove that event,<br>but let's keep it in case we should need it in the future.<br><br>Change-Id: I07aad62d25566d6068a95797915bb97fc3c66328<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index e879059..4ed95dd 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -1336,6 +1336,13 @@</span><br><span>            lchan_fail_to(LCHAN_ST_UNUSED, "LCHAN_EV_TS_ERROR");</span><br><span>               return;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   case LCHAN_EV_RLL_ERR_IND:</span><br><span style="color: hsl(120, 100%, 40%);">+            /* let's just ignore this.  We are already logging the</span><br><span style="color: hsl(120, 100%, 40%);">+             * fact that this message was received inside</span><br><span style="color: hsl(120, 100%, 40%);">+          * abis_rsl.c.  There can be any number of reasons why the</span><br><span style="color: hsl(120, 100%, 40%);">+             * radio link layer failed */</span><br><span style="color: hsl(120, 100%, 40%);">+         return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    default:</span><br><span>             return;</span><br><span>      }</span><br><span>@@ -1464,6 +1471,7 @@</span><br><span>    .allstate_action = lchan_fsm_allstate_action,</span><br><span>        .allstate_event_mask = 0</span><br><span>             | S(LCHAN_EV_TS_ERROR)</span><br><span style="color: hsl(120, 100%, 40%);">+                | S(LCHAN_EV_RLL_ERR_IND)</span><br><span>            ,</span><br><span>    .timer_cb = lchan_fsm_timer_cb,</span><br><span>      .cleanup = lchan_fsm_cleanup,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19389">change 19389</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19389"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I07aad62d25566d6068a95797915bb97fc3c66328 </div>
<div style="display:none"> Gerrit-Change-Number: 19389 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>