<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/19406">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Hoernchen: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Allow setting power-ramp max-initial to negative values<br><br>This allows for instance ramping up from -10 dBm -> -4 dBm if NOMTXPOWER<br>of SDR is really low (below 0dBm) or because the max_power_red is >=<br>NOMTXPOWER.<br><br>Related: SYS#4920<br>Change-Id: I0f27fb7b86b58c5a80f5342b66ff4f5d1b775498<br>---<br>M src/common/tx_power.c<br>M src/common/vty.c<br>2 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/tx_power.c b/src/common/tx_power.c</span><br><span>index 8f50b0f..7f134ca 100644</span><br><span>--- a/src/common/tx_power.c</span><br><span>+++ b/src/common/tx_power.c</span><br><span>@@ -268,8 +268,8 @@</span><br><span>     if (we_are_ramping_up(trx)) {</span><br><span>                if (tpp->p_total_tgt_mdBm <= tpp->ramp.max_initial_pout_mdBm) {</span><br><span>                     LOGPTRX(trx, DL1C, LOGL_INFO,</span><br><span style="color: hsl(0, 100%, 40%);">-                           "target_power(%d) is below max.initial power\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                              tpp->p_total_tgt_mdBm);</span><br><span style="color: hsl(120, 100%, 40%);">+                            "target_power (%d mdBm) is below or equal to 'power ramp max-initial' power (%d mdBm)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                           tpp->p_total_tgt_mdBm, tpp->ramp.max_initial_pout_mdBm);</span><br><span>                       /* new setting is below the maximum initial output</span><br><span>                    * power, so we can directly jump to this level */</span><br><span>                   tpp->p_total_cur_mdBm = tpp->p_total_tgt_mdBm;</span><br><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index 91f3706..3f24d66 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -723,7 +723,7 @@</span><br><span> </span><br><span> #define PR_STR "Power-Ramp settings\n"</span><br><span> DEFUN(cfg_trx_pr_max_initial, cfg_trx_pr_max_initial_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-    "power-ramp max-initial <0-100000> (dBm|mdBm)",</span><br><span style="color: hsl(120, 100%, 40%);">+       "power-ramp max-initial <-10000-100000> (dBm|mdBm)",</span><br><span>         PR_STR "Maximum initial power\n"</span><br><span>   "Value\n" DB_MDB_STR)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/19406">change 19406</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/19406"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0f27fb7b86b58c5a80f5342b66ff4f5d1b775498 </div>
<div style="display:none"> Gerrit-Change-Number: 19406 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>