<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/19213">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Clear Command: set cause value to "Call Control"<br><br>So far, by failing to initialize the cause value, we always send a Clear<br>Command cause == 0, which actually means "Radio Interface Message Failure".<br>This is seen in all my logged network traces of osmo-msc lab testing.<br><br>"Call Control" seems to be the only cause value that remotely fits a normal<br>release procedure, even if it was not voice call related, see 3GPP TS 48.008<br>3.2.1.21.<br><br>Related: OS#4664<br>Change-Id: I1347ed72ae7d7ea73a557b866e764819c5ef8c42<br>---<br>M src/libmsc/msc_a.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c</span><br><span>index 76c0f01..0645c54 100644</span><br><span>--- a/src/libmsc/msc_a.c</span><br><span>+++ b/src/libmsc/msc_a.c</span><br><span>@@ -779,6 +779,9 @@</span><br><span>             struct ran_msg msg = {</span><br><span>                       .msg_type = RAN_MSG_CLEAR_COMMAND,</span><br><span>                   .clear_command = {</span><br><span style="color: hsl(120, 100%, 40%);">+                            /* "Call Control" is the only cause code listed in 3GPP TS 48.008 3.2.1.21 CLEAR COMMAND</span><br><span style="color: hsl(120, 100%, 40%);">+                             * that qualifies for a normal release situation. (OS#4664) */</span><br><span style="color: hsl(120, 100%, 40%);">+                                .gsm0808_cause = GSM0808_CAUSE_CALL_CONTROL,</span><br><span>                                 .csfb_ind = (vsub && vsub->sgs_fsm->state == SGS_UE_ST_ASSOCIATED),</span><br><span>                    },</span><br><span>           };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/19213">change 19213</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/19213"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1347ed72ae7d7ea73a557b866e764819c5ef8c42 </div>
<div style="display:none"> Gerrit-Change-Number: 19213 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>