<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/19380">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Hoernchen: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts_shutdown_fsm: Fix switching too quickly to state WAIT_TRX_CLOSED<br><br>Ramping down was set up with a target of -10 dBm, but then the code only<br>waited for all TRXs to be at least 0dBm, meaning that if operating more<br>than 1 TRX, the FSM could transit to state ST_WAIT_TRX_CLOSED when one<br>TRX reached -10 and other were already equal or below 0 (but not yet<br>-10). As a result, later on, when other TRXs reached -10 dBm they would<br>trigger EV_TRX_RAMP_COMPL which was not expected (no use) in<br>ST_WAIT_TRX_CLOSED.<br><br>Related: SYS#4864<br>Change-Id: If7af0b138efe78ec591c199a19fc22b304416a13<br>---<br>M src/common/bts_shutdown_fsm.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/bts_shutdown_fsm.c b/src/common/bts_shutdown_fsm.c</span><br><span>index c81a4ab..0ac3078 100644</span><br><span>--- a/src/common/bts_shutdown_fsm.c</span><br><span>+++ b/src/common/bts_shutdown_fsm.c</span><br><span>@@ -32,6 +32,8 @@</span><br><span> </span><br><span> #define X(s) (1 << (s))</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define BTS_SHUTDOWN_POWER_RAMP_TGT -10</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static const struct osmo_tdef_state_timeout bts_shutdown_fsm_timeouts[32] = {</span><br><span> [BTS_SHUTDOWN_ST_WAIT_RAMP_DOWN_COMPL] = { .T = -1 },</span><br><span> [BTS_SHUTDOWN_ST_WAIT_TRX_CLOSED] = { .T = -2 },</span><br><span>@@ -83,7 +85,7 @@</span><br><span> llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span> if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED)</span><br><span> continue;</span><br><span style="color: hsl(0, 100%, 40%);">- power_ramp_start(trx, to_mdB(-10), 1, ramp_down_compl_cb);</span><br><span style="color: hsl(120, 100%, 40%);">+ power_ramp_start(trx, to_mdB(BTS_SHUTDOWN_POWER_RAMP_TGT), 1, ramp_down_compl_cb);</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>@@ -100,7 +102,7 @@</span><br><span> </span><br><span> llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span> if (trx->mo.nm_state.operational == NM_OPSTATE_ENABLED &&</span><br><span style="color: hsl(0, 100%, 40%);">- trx->power_params.p_total_cur_mdBm > 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ trx->power_params.p_total_cur_mdBm > BTS_SHUTDOWN_POWER_RAMP_TGT)</span><br><span> remaining++;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/19380">change 19380</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/19380"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If7af0b138efe78ec591c199a19fc22b304416a13 </div>
<div style="display:none"> Gerrit-Change-Number: 19380 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>