<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19381">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">i460_mux: correctly re-initalize when deleting subchannels<br><br>When a subchannel is deleted using osmo_i460_subchan_del() the entire<br>schan struct is cleared. However, this means that also the mux.tx_queue<br>llist head is overwritten with zeros. The llist head is the uninitalized<br>and on the next use of the subchannel the programm will segfault.<br><br>Lets re-initalize the subchannel correctly like it is also done in<br>osmo_i460_ts_init() for all subchannels.<br><br>Change-Id: I937a9d4db95f44a860cd2c5dbb660dc1970b9a49<br>---<br>M src/gsm/i460_mux.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/19381/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/i460_mux.c b/src/gsm/i460_mux.c</span><br><span>index 3fb63ec..d930fcb 100644</span><br><span>--- a/src/gsm/i460_mux.c</span><br><span>+++ b/src/gsm/i460_mux.c</span><br><span>@@ -358,6 +358,8 @@</span><br><span> {</span><br><span>        talloc_free(schan->demux.out_bitbuf);</span><br><span>     memset(schan, 0, sizeof(*schan));</span><br><span style="color: hsl(120, 100%, 40%);">+     schan->rate = OSMO_I460_RATE_NONE;</span><br><span style="color: hsl(120, 100%, 40%);">+ INIT_LLIST_HEAD(&schan->mux.tx_queue);</span><br><span> }</span><br><span> </span><br><span> /*! @} */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19381">change 19381</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19381"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I937a9d4db95f44a860cd2c5dbb660dc1970b9a49 </div>
<div style="display:none"> Gerrit-Change-Number: 19381 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>