<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19358">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pkg-config: Use "Requires" for external libs such as talloc.<br><br>According to https://people.freedesktop.org/~dbn/pkg-config-guide.html<br>we should use Requires or even Requires.private, not Libs for external<br>dependencies.<br><br>Change-Id: I2aa716125880b444e091812ab800b29a7b905b4f<br>---<br>M libosmocodec.pc.in<br>M libosmocoding.pc.in<br>M libosmocore.pc.in<br>M libosmoctrl.pc.in<br>M libosmogb.pc.in<br>M libosmogsm.pc.in<br>M libosmosim.pc.in<br>M libosmousb.pc.in<br>8 files changed, 19 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/19358/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/libosmocodec.pc.in b/libosmocodec.pc.in</span><br><span>index 9e058ef..a6a9d78 100644</span><br><span>--- a/libosmocodec.pc.in</span><br><span>+++ b/libosmocodec.pc.in</span><br><span>@@ -6,6 +6,6 @@</span><br><span> Name: Osmocom Codec related utilities Library</span><br><span> Description: C Utility Library</span><br><span> Version: @VERSION@</span><br><span style="color: hsl(0, 100%, 40%);">-Libs: -L${libdir} @TALLOC_LIBS@ -losmocodec</span><br><span style="color: hsl(0, 100%, 40%);">-Cflags: -I${includedir}/ @TALLOC_CFLAGS@</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+Requires: talloc</span><br><span style="color: hsl(120, 100%, 40%);">+Libs: -L${libdir} -losmocodec</span><br><span style="color: hsl(120, 100%, 40%);">+Cflags: -I${includedir}/</span><br><span>diff --git a/libosmocoding.pc.in b/libosmocoding.pc.in</span><br><span>index d1d03c4..826a3f7 100644</span><br><span>--- a/libosmocoding.pc.in</span><br><span>+++ b/libosmocoding.pc.in</span><br><span>@@ -6,6 +6,6 @@</span><br><span> Name: Osmocom L1 transcoding Library</span><br><span> Description: C Utility Library</span><br><span> Version: @VERSION@</span><br><span style="color: hsl(0, 100%, 40%);">-Libs: -L${libdir} @TALLOC_LIBS@ -losmocoding -losmocodec -losmogsm -losmocore</span><br><span style="color: hsl(0, 100%, 40%);">-Cflags: -I${includedir}/ @TALLOC_CFLAGS@</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+Requires: talloc libosmocodec libosmocgsm libosmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Libs: -L${libdir} -losmocoding</span><br><span style="color: hsl(120, 100%, 40%);">+Cflags: -I${includedir}/</span><br><span>diff --git a/libosmocore.pc.in b/libosmocore.pc.in</span><br><span>index 80f17c8..925265d 100644</span><br><span>--- a/libosmocore.pc.in</span><br><span>+++ b/libosmocore.pc.in</span><br><span>@@ -6,6 +6,7 @@</span><br><span> Name: Osmocom Core Library</span><br><span> Description: C Utility Library</span><br><span> Version: @VERSION@</span><br><span style="color: hsl(0, 100%, 40%);">-Libs: -L${libdir} @TALLOC_LIBS@ -losmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Requires: talloc</span><br><span style="color: hsl(120, 100%, 40%);">+Libs: -L${libdir} -losmocore</span><br><span> Libs.private: @PTHREAD_LIBS@ @LIBSCTP_LIBS@</span><br><span style="color: hsl(0, 100%, 40%);">-Cflags: -I${includedir}/ @TALLOC_CFLAGS@ @PTHREAD_CFLAGS@</span><br><span style="color: hsl(120, 100%, 40%);">+Cflags: -I${includedir}/ @PTHREAD_CFLAGS@</span><br><span>diff --git a/libosmoctrl.pc.in b/libosmoctrl.pc.in</span><br><span>index 4676b31..c110d8e 100644</span><br><span>--- a/libosmoctrl.pc.in</span><br><span>+++ b/libosmoctrl.pc.in</span><br><span>@@ -6,6 +6,6 @@</span><br><span> Name: Osmocom Control Interface Library</span><br><span> Description: C Utility Library</span><br><span> Version: @VERSION@</span><br><span style="color: hsl(0, 100%, 40%);">-Libs: -L${libdir} @TALLOC_LIBS@ -losmoctrl -losmogsm -losmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Requires: talloc libosmogsm libosmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Libs: -L${libdir} -losmoctrl</span><br><span> Cflags: -I${includedir}/</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>diff --git a/libosmogb.pc.in b/libosmogb.pc.in</span><br><span>index a163cc4..769fea4 100644</span><br><span>--- a/libosmogb.pc.in</span><br><span>+++ b/libosmogb.pc.in</span><br><span>@@ -6,6 +6,6 @@</span><br><span> Name: Osmocom GPRS Gb Library</span><br><span> Description: Osmocom GPRS Gb Interface (NS/BSSGP) Library</span><br><span> Version: @VERSION@</span><br><span style="color: hsl(0, 100%, 40%);">-Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Requires: talloc libosmovty libosmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Libs: -L${libdir} -losmogb</span><br><span> Cflags: -I${includedir}/ -fno-strict-aliasing</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>diff --git a/libosmogsm.pc.in b/libosmogsm.pc.in</span><br><span>index 0160be8..956897b 100644</span><br><span>--- a/libosmogsm.pc.in</span><br><span>+++ b/libosmogsm.pc.in</span><br><span>@@ -6,6 +6,6 @@</span><br><span> Name: Osmocom GSM Core Library</span><br><span> Description: GSM Core Library</span><br><span> Version: @VERSION@</span><br><span style="color: hsl(0, 100%, 40%);">-Libs: -L${libdir} @TALLOC_LIBS@ -losmogsm -losmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Requires: talloc libosmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Libs: -L${libdir} -losmogsm</span><br><span> Cflags: -I${includedir}/</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>diff --git a/libosmosim.pc.in b/libosmosim.pc.in</span><br><span>index 83777c3..fbcdbe4 100644</span><br><span>--- a/libosmosim.pc.in</span><br><span>+++ b/libosmosim.pc.in</span><br><span>@@ -6,6 +6,6 @@</span><br><span> Name: Osmocom SIM card related utilities Library</span><br><span> Description: C Utility Library</span><br><span> Version: @VERSION@</span><br><span style="color: hsl(0, 100%, 40%);">-Libs: -L${libdir} @TALLOC_LIBS@ -losmosim -losmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Requires: talloc libosmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Libs: -L${libdir} -losmosim</span><br><span> Cflags: -I${includedir}/</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>diff --git a/libosmousb.pc.in b/libosmousb.pc.in</span><br><span>index ce6d271..4027074 100644</span><br><span>--- a/libosmousb.pc.in</span><br><span>+++ b/libosmousb.pc.in</span><br><span>@@ -6,6 +6,6 @@</span><br><span> Name: Osmocom libusb (USB) integration</span><br><span> Description: C Utility Library</span><br><span> Version: @VERSION@</span><br><span style="color: hsl(0, 100%, 40%);">-Libs: -L${libdir} @TALLOC_LIBS@ -losmousb -losmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Requires: talloc libosmocore</span><br><span style="color: hsl(120, 100%, 40%);">+Libs: -L${libdir} -losmousb</span><br><span> Cflags: -I${includedir}/</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19358">change 19358</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19358"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2aa716125880b444e091812ab800b29a7b905b4f </div>
<div style="display:none"> Gerrit-Change-Number: 19358 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>