<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19260">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Hoernchen: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess_recvmsg: Clean up release steps upon error condition<br><br>Related: OS#4624<br>Change-Id: I47a3e477d6861620a741193d3d3d3e286836fd44<br>---<br>M src/input/ipaccess.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index 3ff59f4..8a7142d 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -330,12 +330,15 @@</span><br><span>  }</span><br><span>    return 0;</span><br><span> err:</span><br><span style="color: hsl(0, 100%, 40%);">-       osmo_fd_unregister(bfd);</span><br><span>     if (bfd->fd != -1) {</span><br><span style="color: hsl(120, 100%, 40%);">+               osmo_fd_unregister(bfd);</span><br><span>             close(bfd->fd);</span><br><span>           bfd->fd = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+              /* This is a BSC accepted socket, bfd->data holds a reference to line, drop it */</span><br><span style="color: hsl(120, 100%, 40%);">+          OSMO_ASSERT(bfd->data == line);</span><br><span style="color: hsl(120, 100%, 40%);">+            bfd->data = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+          e1inp_line_put2(line, "ipa_bfd");</span><br><span>  }</span><br><span style="color: hsl(0, 100%, 40%);">-       e1inp_line_put2(line, "ipa_bfd");</span><br><span>  return -1;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19260">change 19260</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/19260"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I47a3e477d6861620a741193d3d3d3e286836fd44 </div>
<div style="display:none"> Gerrit-Change-Number: 19260 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>