<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19257">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess: Drop e1inp_line reference in ipacess_drop()<br><br>the bfd->data handles a reference to the e1np_line (obtained through<br>e1inp_line_get() during bfd setup), so remember to drop it under this<br>condition.<br><br>Related: OS#4624<br>Change-Id: I418064df04872befe2e936e21768b6ea01263120<br>---<br>M src/input/ipaccess.c<br>1 file changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index 5d17839..08b34a4 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -92,6 +92,13 @@</span><br><span>               osmo_fd_unregister(bfd);</span><br><span>             close(bfd->fd);</span><br><span>           bfd->fd = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+              /* This is BSC code, ipaccess_drop() is only called for</span><br><span style="color: hsl(120, 100%, 40%);">+                  accepted() sockets, hence the bfd holds a reference to</span><br><span style="color: hsl(120, 100%, 40%);">+                e1inp_line in ->data that needs to be released */</span><br><span style="color: hsl(120, 100%, 40%);">+               OSMO_ASSERT(bfd->data == line);</span><br><span style="color: hsl(120, 100%, 40%);">+            bfd->data = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+          e1inp_line_put2(line, "ipa_bfd");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                ret = -ENOENT;</span><br><span>       }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/19257">change 19257</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/19257"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I418064df04872befe2e936e21768b6ea01263120 </div>
<div style="display:none"> Gerrit-Change-Number: 19257 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>