<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/19309">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">encoding: drop log_alert_exit(), use OSMO_ASSERT() instead<br><br>Change-Id: Id5ef1c3c08dc7f264ad801e519d727d86f5ae5b8<br>---<br>M src/encoding.cpp<br>1 file changed, 2 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index 92944f0..2564575 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -433,13 +433,6 @@</span><br><span>   return plen;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static inline void log_alert_exit(const char * error)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-     LOGP(DRLCMACUL, LOGL_ERROR, "%s", error);</span><br><span style="color: hsl(0, 100%, 40%);">-     pcu_tx_txt_ind(PCU_OML_ALERT, error);</span><br><span style="color: hsl(0, 100%, 40%);">-   exit(1);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*</span><br><span>  * Immediate assignment, sent on the CCCH/AGCH</span><br><span>  * see GSM 04.08, 9.1.18 and GSM 44.018, 9.1.18 + 10.5.2.16</span><br><span>@@ -494,9 +487,7 @@</span><br><span>       // A zero-length LV.  Just write L=0.</span><br><span>        bitvec_write_field(dest, &wp,0,8);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      if ((wp % 8))</span><br><span style="color: hsl(0, 100%, 40%);">-           log_alert_exit("Length of IMM.ASS without rest octets is not "</span><br><span style="color: hsl(0, 100%, 40%);">-                               "multiple of 8 bits, PLEASE FIX!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_ASSERT(wp % 8 == 0);</span><br><span> </span><br><span>        plen = wp / 8;</span><br><span> </span><br><span>@@ -748,9 +739,7 @@</span><br><span>     bitvec_set_bytes(dest, mi, mi_len);        // Mobile Identity</span><br><span>        wp += mi_len * 8;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if ((wp % 8))</span><br><span style="color: hsl(0, 100%, 40%);">-           log_alert_exit("Length of PAG.REQ without rest octets is not "</span><br><span style="color: hsl(0, 100%, 40%);">-                               "multiple of 8 bits, PLEASE FIX!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_ASSERT(wp % 8 == 0);</span><br><span> </span><br><span>        plen = wp / 8;</span><br><span>       bitvec_write_field(dest, &wp,0x0,1); // "L" Notification List Number; NLN(PCH) = off</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/19309">change 19309</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/19309"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id5ef1c3c08dc7f264ad801e519d727d86f5ae5b8 </div>
<div style="display:none"> Gerrit-Change-Number: 19309 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>