<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19322">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/PCUIF_Types: make PCUIF version configurable<br><br>When changing the PCUIF, we have to maintain backwards compatibility<br>with the release versions of both osmo-pcu and osmo-bts, not only<br>with the recent master.  In order to achieve that, let's introduce<br>'mp_pcuif_version', so the PCUIF version can be adjusted.<br><br>Change-Id: I3cf7f908e606b91dd2cbddc168827dd074aed052<br>Related: SYS#4868, OS#4547<br>---<br>M library/PCUIF_Types.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 8 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/19322/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn</span><br><span>index 8ce41c4..089403c 100644</span><br><span>--- a/library/PCUIF_Types.ttcn</span><br><span>+++ b/library/PCUIF_Types.ttcn</span><br><span>@@ -14,8 +14,13 @@</span><br><span> import from General_Types all;</span><br><span> import from Osmocom_Types all;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+modulepar {</span><br><span style="color: hsl(120, 100%, 40%);">+     /* PCUIF version supported by the IUT */</span><br><span style="color: hsl(120, 100%, 40%);">+      PCUIF_Version mp_pcuif_version := 9;</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> const charstring PCU_SOCK_DEFAULT := "/tmp/pcu_bts";</span><br><span style="color: hsl(0, 100%, 40%);">-const uint32_t PCU_IF_VERSION := 9;</span><br><span style="color: hsl(120, 100%, 40%);">+type integer PCUIF_Version (9); /* supported versions */</span><br><span> </span><br><span> type enumerated PCUIF_MsgType {</span><br><span>     PCU_IF_MSG_DATA_REQ             ('00'O),</span><br><span>@@ -698,7 +703,7 @@</span><br><span> }</span><br><span> template PCUIF_Message tr_PCUIF_INFO_IND(template uint8_t bts_nr := ?,</span><br><span>                                         template PCUIF_Flags flags := ?,</span><br><span style="color: hsl(0, 100%, 40%);">-                                        template uint32_t version := PCU_IF_VERSION) := {</span><br><span style="color: hsl(120, 100%, 40%);">+                                     template uint32_t version := mp_pcuif_version) := {</span><br><span>         msg_type := PCU_IF_MSG_INFO_IND,</span><br><span>     bts_nr := bts_nr,</span><br><span>    spare := ?,</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 09d91a0..20e3582 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -60,7 +60,7 @@</span><br><span> </span><br><span> /* FIXME: make sure to use parameters from mp_gb_cfg.cell_id in the PCU INFO IND */</span><br><span> friend template (value) PCUIF_info_ind ts_PCUIF_INFO_default := {</span><br><span style="color: hsl(0, 100%, 40%);">-    version := PCU_IF_VERSION,</span><br><span style="color: hsl(120, 100%, 40%);">+    version := PCUIF_Types.mp_pcuif_version,</span><br><span>     flags := c_PCUIF_Flags_default,</span><br><span>      trx := valueof(ts_PCUIF_InfoTrxs_def),</span><br><span>       bsic := 7,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19322">change 19322</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19322"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3cf7f908e606b91dd2cbddc168827dd074aed052 </div>
<div style="display:none"> Gerrit-Change-Number: 19322 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>