<p>pespin <strong>uploaded patch set #3</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19287">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Move struct gsm_bts: gsm_data.* => bts.*<br><br>Place all code related to the object into the related file.<br><br>Having all the data model in one file made sense in early stage of<br>development to make progress quickly, but nowadays it hurts more than<br>helps, due to constantly growing size and more and more bits being<br>added to the model, gaining in complexity.<br><br>Currently, having lots of different objects mixed up in gsm_data.h is a hole<br>of despair, where nobody can make any sense were to properly put new stuff<br>in, ending up with functions related to same object in different files<br>or with wrong prefixes, declarations of non-existing functions, etc.<br>because people cannot make up their mind on strict relation to objects<br>in the data model.<br>Splitting them in files really helps finding code operating on a<br>specific object and helping with logically splitting in the future.<br><br>Change-Id: I00c15f5285b5c1a0109279b7ab192d5467a04ece<br>---<br>M include/osmocom/bsc/Makefile.am<br>A include/osmocom/bsc/bts.h<br>M include/osmocom/bsc/gsm_data.h<br>M src/ipaccess/Makefile.am<br>M src/ipaccess/ipaccess-config.c<br>M src/osmo-bsc/Makefile.am<br>M src/osmo-bsc/abis_nm.c<br>M src/osmo-bsc/abis_om2000.c<br>M src/osmo-bsc/abis_om2000_vty.c<br>M src/osmo-bsc/abis_rsl.c<br>M src/osmo-bsc/acc_ramp.c<br>M src/osmo-bsc/assignment_fsm.c<br>M src/osmo-bsc/bsc_ctrl_commands.c<br>M src/osmo-bsc/bsc_init.c<br>M src/osmo-bsc/bsc_rf_ctrl.c<br>M src/osmo-bsc/bsc_vty.c<br>A src/osmo-bsc/bts.c<br>M src/osmo-bsc/bts_ericsson_rbs2000.c<br>M src/osmo-bsc/bts_ipaccess_nanobts.c<br>M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c<br>M src/osmo-bsc/bts_nokia_site.c<br>M src/osmo-bsc/bts_siemens_bs11.c<br>M src/osmo-bsc/bts_sysmobts.c<br>M src/osmo-bsc/bts_unknown.c<br>M src/osmo-bsc/cbch_scheduler.c<br>M src/osmo-bsc/chan_alloc.c<br>M src/osmo-bsc/codec_pref.c<br>M src/osmo-bsc/e1_config.c<br>M src/osmo-bsc/gsm_04_08_rr.c<br>M src/osmo-bsc/gsm_08_08.c<br>M src/osmo-bsc/gsm_data.c<br>M src/osmo-bsc/handover_decision.c<br>M src/osmo-bsc/handover_decision_2.c<br>M src/osmo-bsc/handover_fsm.c<br>M src/osmo-bsc/handover_logic.c<br>M src/osmo-bsc/handover_vty.c<br>M src/osmo-bsc/lchan_fsm.c<br>M src/osmo-bsc/lchan_rtp_fsm.c<br>M src/osmo-bsc/lchan_select.c<br>M src/osmo-bsc/meas_feed.c<br>M src/osmo-bsc/neighbor_ident_vty.c<br>M src/osmo-bsc/osmo_bsc_bssap.c<br>M src/osmo-bsc/osmo_bsc_ctrl.c<br>M src/osmo-bsc/osmo_bsc_filter.c<br>M src/osmo-bsc/osmo_bsc_grace.c<br>M src/osmo-bsc/osmo_bsc_main.c<br>M src/osmo-bsc/osmo_bsc_msc.c<br>M src/osmo-bsc/osmo_bsc_sigtran.c<br>M src/osmo-bsc/paging.c<br>M src/osmo-bsc/pcu_sock.c<br>M src/osmo-bsc/rest_octets.c<br>M src/osmo-bsc/smscb.c<br>M src/osmo-bsc/system_information.c<br>M src/osmo-bsc/timeslot_fsm.c<br>M src/utils/Makefile.am<br>M src/utils/bs11_config.c<br>M tests/abis/Makefile.am<br>M tests/abis/abis_test.c<br>M tests/bsc/Makefile.am<br>M tests/codec_pref/codec_pref_test.c<br>M tests/gsm0408/Makefile.am<br>M tests/gsm0408/gsm0408_test.c<br>M tests/handover/Makefile.am<br>M tests/handover/handover_test.c<br>M tests/nanobts_omlattr/Makefile.am<br>M tests/nanobts_omlattr/nanobts_omlattr_test.c<br>66 files changed, 1,471 insertions(+), 1,354 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/19287/3</pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19287">change 19287</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19287"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I00c15f5285b5c1a0109279b7ab192d5467a04ece </div>
<div style="display:none"> Gerrit-Change-Number: 19287 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>