<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/19272">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: Avoid ultra-long multi-line strings cluttering talloc reports<br><br>The talloc_asprintf() series includes an unconditional call to<br>talloc_set_name_const(), turning the entire long constructed string<br>into the name of the talloc object.  That simply doesn't work when<br>creating kilobytes-sized VTY reference strings including linefeeds.<br><br>Let's add an explicit talloc_set_name_const() to prevent this.<br><br>Change-Id: Ibd77684b88cc3572047daa98c9a6b9119fba041b<br>Closes: OS#4668<br>---<br>M src/vty/logging_vty.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c</span><br><span>index c51b437..0e1782a 100644</span><br><span>--- a/src/vty/logging_vty.c</span><br><span>+++ b/src/vty/logging_vty.c</span><br><span>@@ -337,6 +337,9 @@</span><br><span>         osmo_talloc_asprintf(tall_log_ctx, cmd_str, ") %s", level_args);</span><br><span>   osmo_talloc_asprintf(tall_log_ctx, doc_str, "%s", level_strs);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  talloc_set_name_const(cmd_str, "vty_log_level_cmd_str");</span><br><span style="color: hsl(120, 100%, 40%);">+    talloc_set_name_const(doc_str, "vty_log_level_doc_str");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         cmd->string = cmd_str;</span><br><span>    cmd->doc = doc_str;</span><br><span> }</span><br><span>@@ -1048,6 +1051,9 @@</span><br><span>  osmo_talloc_asprintf(tall_log_ctx, doc_str,</span><br><span>                       "Arbitrary message to log on given category and log level\n");</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     talloc_set_name_const(cmd_str, "vty_logp_cmd_str");</span><br><span style="color: hsl(120, 100%, 40%);">+ talloc_set_name_const(doc_str, "vty_logp_doc_str");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      cmd->string = cmd_str;</span><br><span>    cmd->doc = doc_str;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/19272">change 19272</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/19272"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibd77684b88cc3572047daa98c9a6b9119fba041b </div>
<div style="display:none"> Gerrit-Change-Number: 19272 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>