<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/19231">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
tnt: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">actually implement the superchannel mode<br><br>In superchannel mode, all 31 TS are grouped together.<br><br>There is no way to enable it yet, see next patch.<br><br>Change-Id: Id340b1925471f427deb6cda7eb54e80dfc71faec<br>---<br>M src/e1d.h<br>M src/intf_line.c<br>M src/vty.c<br>3 files changed, 172 insertions(+), 59 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/e1d.h b/src/e1d.h</span><br><span>index 2b8e32b..fca7d3e 100644</span><br><span>--- a/src/e1d.h</span><br><span>+++ b/src/e1d.h</span><br><span>@@ -85,6 +85,7 @@</span><br><span> };</span><br><span> </span><br><span> extern const struct value_string e1_driver_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string e1_line_mode_names[];</span><br><span> </span><br><span> struct e1_intf {</span><br><span> struct llist_head list;</span><br><span>diff --git a/src/intf_line.c b/src/intf_line.c</span><br><span>index 421c528..af0d45d 100644</span><br><span>--- a/src/intf_line.c</span><br><span>+++ b/src/intf_line.c</span><br><span>@@ -177,7 +177,7 @@</span><br><span> oi += cl;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ return len;</span><br><span> }</span><br><span> </span><br><span> static int</span><br><span>@@ -233,6 +233,83 @@</span><br><span> return len;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* read from a timeslot-FD (direction application -> hardware) */</span><br><span style="color: hsl(120, 100%, 40%);">+static int</span><br><span style="color: hsl(120, 100%, 40%);">+_e1_ts_read(struct e1_ts *ts, uint8_t *buf, size_t len)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int l;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (ts->mode) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case E1_TS_MODE_RAW:</span><br><span style="color: hsl(120, 100%, 40%);">+ l = read(ts->fd, buf, len);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: handle underflow */</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case E1_TS_MODE_HDLCFCS:</span><br><span style="color: hsl(120, 100%, 40%);">+ l = _e1_tx_hdlcfs(ts, buf, len);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (l < 0 && errno != EAGAIN) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPTS(ts, DE1D, LOGL_ERROR, "dead socket during read: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+ e1_ts_stop(ts);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (l < len) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPTS(ts, DE1D, LOGL_NOTICE, "TS read underflow: We had %zu bytes to read, "</span><br><span style="color: hsl(120, 100%, 40%);">+ "but socket returned only %d\n", len, l);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return l;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void</span><br><span style="color: hsl(120, 100%, 40%);">+_e1_line_mux_out_channelized(struct e1_line *line, uint8_t *buf, int fts)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(line->mode == E1_LINE_MODE_CHANNELIZED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Scan timeslots */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (int tsn=1; tsn<32; tsn++)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct e1_ts *ts = &line->ts[tsn];</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t buf_ts[fts];</span><br><span style="color: hsl(120, 100%, 40%);">+ int l;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ts->mode == E1_TS_MODE_OFF)</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ l = _e1_ts_read(ts, buf_ts, sizeof(buf_ts));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (l <= 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (int i=0; i<l; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ buf[tsn+(i*32)] = buf_ts[i];</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void</span><br><span style="color: hsl(120, 100%, 40%);">+_e1_line_mux_out_superchan(struct e1_line *line, uint8_t *buf, int fts)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct e1_ts *ts = &line->superchan;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t sc_buf[31*fts];</span><br><span style="color: hsl(120, 100%, 40%);">+ int l;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(line->mode == E1_LINE_MODE_SUPERCHANNEL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ts->mode == E1_TS_MODE_OFF)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* first pull all we need out of the source */</span><br><span style="color: hsl(120, 100%, 40%);">+ l = _e1_ts_read(ts, sc_buf, sizeof(sc_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (l <= 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then form E1 frames from it, sprinkling in some gaps for TS0 */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (int i = 0; i < fts; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(buf + i*32 + 1, sc_buf + i*31, 31);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*! generate (multiplex) output data for the specified e1_line</span><br><span> * \param[in] line E1 line for which to genrate output data</span><br><span> * \param[in] buf caller-allocated output buffer for multiplexed data</span><br><span>@@ -247,42 +324,91 @@</span><br><span> tsz = 32 * fts;</span><br><span> memset(buf, 0xff, tsz);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Scan timeslots */</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (line->mode) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case E1_LINE_MODE_CHANNELIZED:</span><br><span style="color: hsl(120, 100%, 40%);">+ _e1_line_mux_out_channelized(line, buf, fts);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case E1_LINE_MODE_SUPERCHANNEL:</span><br><span style="color: hsl(120, 100%, 40%);">+ _e1_line_mux_out_superchan(line, buf, fts);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return tsz;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* write data to a timeslot (hardware -> application direction) */</span><br><span style="color: hsl(120, 100%, 40%);">+static int</span><br><span style="color: hsl(120, 100%, 40%);">+_e1_ts_write(struct e1_ts *ts, const uint8_t *buf, size_t len)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int rv;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (ts->mode) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case E1_TS_MODE_RAW:</span><br><span style="color: hsl(120, 100%, 40%);">+ rv = write(ts->fd, buf, len);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case E1_TS_MODE_HDLCFCS:</span><br><span style="color: hsl(120, 100%, 40%);">+ rv = _e1_rx_hdlcfs(ts, buf, len);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rv < 0 && errno != EAGAIN) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPTS(ts, DE1D, LOGL_ERROR, "dead socket during write: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+ e1_ts_stop(ts);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (rv < len) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPTS(ts, DE1D, LOGL_NOTICE, "TS write overflow: We had %zu bytes to send, "</span><br><span style="color: hsl(120, 100%, 40%);">+ "but write returned only %d\n", len, rv);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return rv;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static int</span><br><span style="color: hsl(120, 100%, 40%);">+_e1_line_demux_in_superchan(struct e1_line *line, const uint8_t *buf, int ftr)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct e1_ts *ts = &line->superchan;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t sc_buf[ftr*31];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(line->mode == E1_LINE_MODE_SUPERCHANNEL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ts->mode == E1_TS_MODE_OFF)</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* first gather input data from multiple frames*/</span><br><span style="color: hsl(120, 100%, 40%);">+ for (int i = 0; i < ftr; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(sc_buf + (i*31), buf + (i*32) + 1, 31);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then dispatch to appropriate action */</span><br><span style="color: hsl(120, 100%, 40%);">+ _e1_ts_write(ts, sc_buf, ftr*31);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static int</span><br><span style="color: hsl(120, 100%, 40%);">+_e1_line_demux_in_channelized(struct e1_line *line, const uint8_t *buf, int ftr)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(line->mode == E1_LINE_MODE_CHANNELIZED);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> for (int tsn=1; tsn<32; tsn++)</span><br><span> {</span><br><span> struct e1_ts *ts = &line->ts[tsn];</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t buf_ts[fts];</span><br><span style="color: hsl(0, 100%, 40%);">- int l;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t buf_ts[ftr];</span><br><span> </span><br><span> if (ts->mode == E1_TS_MODE_OFF)</span><br><span> continue;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- switch (ts->mode) {</span><br><span style="color: hsl(0, 100%, 40%);">- case E1_TS_MODE_RAW:</span><br><span style="color: hsl(0, 100%, 40%);">- l = read(ts->fd, buf_ts, fts);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case E1_TS_MODE_HDLCFCS:</span><br><span style="color: hsl(0, 100%, 40%);">- l = _e1_tx_hdlcfs(ts, buf_ts, fts);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- default:</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(0);</span><br><span style="color: hsl(0, 100%, 40%);">- continue;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ for (int i=0; i<ftr; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ buf_ts[i] = buf[tsn+(i*32)];</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (l < 0 && errno != EAGAIN) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPTS(ts, DE1D, LOGL_ERROR, "dead socket during read: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">- strerror(errno));</span><br><span style="color: hsl(0, 100%, 40%);">- e1_ts_stop(ts);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (l <= 0)</span><br><span style="color: hsl(0, 100%, 40%);">- continue;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- for (int i=0; i<l; i++)</span><br><span style="color: hsl(0, 100%, 40%);">- buf[tsn+(i*32)] = buf_ts[i];</span><br><span style="color: hsl(120, 100%, 40%);">+ _e1_ts_write(ts, buf_ts, ftr);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- return tsz;</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span> }</span><br><span> </span><br><span> /*! de-multiplex E1 line data to the individual timeslots.</span><br><span>@@ -303,36 +429,12 @@</span><br><span> ftr = size / 32;</span><br><span> OSMO_ASSERT(size % 32 == 0);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- for (int tsn=1; tsn<32; tsn++)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- struct e1_ts *ts = &line->ts[tsn];</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t buf_ts[ftr];</span><br><span style="color: hsl(0, 100%, 40%);">- int rv;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (ts->mode == E1_TS_MODE_OFF)</span><br><span style="color: hsl(0, 100%, 40%);">- continue;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- for (int i=0; i<ftr; i++)</span><br><span style="color: hsl(0, 100%, 40%);">- buf_ts[i] = buf[tsn+(i*32)];</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- switch (ts->mode) {</span><br><span style="color: hsl(0, 100%, 40%);">- case E1_TS_MODE_RAW:</span><br><span style="color: hsl(0, 100%, 40%);">- rv = write(ts->fd, buf_ts, ftr);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case E1_TS_MODE_HDLCFCS:</span><br><span style="color: hsl(0, 100%, 40%);">- rv = _e1_rx_hdlcfs(ts, buf_ts, ftr);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- default:</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(0);</span><br><span style="color: hsl(0, 100%, 40%);">- continue;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- if (rv < 0 && errno != EAGAIN) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPTS(ts, DE1D, LOGL_ERROR, "dead socket during write: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">- strerror(errno));</span><br><span style="color: hsl(0, 100%, 40%);">- e1_ts_stop(ts);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (line->mode) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case E1_LINE_MODE_CHANNELIZED:</span><br><span style="color: hsl(120, 100%, 40%);">+ return _e1_line_demux_in_channelized(line, buf, ftr);</span><br><span style="color: hsl(120, 100%, 40%);">+ case E1_LINE_MODE_SUPERCHANNEL:</span><br><span style="color: hsl(120, 100%, 40%);">+ return _e1_line_demux_in_superchan(line, buf, ftr);</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(0);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return 0;</span><br><span> }</span><br><span>diff --git a/src/vty.c b/src/vty.c</span><br><span>index 5e3f37c..0690177 100644</span><br><span>--- a/src/vty.c</span><br><span>+++ b/src/vty.c</span><br><span>@@ -93,11 +93,18 @@</span><br><span> { 0, NULL }</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string e1_line_mode_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ { E1_LINE_MODE_CHANNELIZED, "CHANNELIZED" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { E1_LINE_MODE_SUPERCHANNEL, "SUPERCHANNEL" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { 0, NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void vty_dump_line(struct vty *vty, const struct e1_line *line)</span><br><span> {</span><br><span> int tn;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- vty_out(vty, "Interface #%u, Line #%u:%s", line->intf->id, line->id, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "Interface #%u, Line #%u, Mode %s:%s", line->intf->id, line->id,</span><br><span style="color: hsl(120, 100%, 40%);">+ get_value_string(e1_line_mode_names, line->mode), VTY_NEWLINE);</span><br><span> </span><br><span> for (tn = 0; tn < ARRAY_SIZE(line->ts); tn++) {</span><br><span> const struct e1_ts *ts = &line->ts[tn];</span><br><span>@@ -105,6 +112,9 @@</span><br><span> ts->id, get_value_string(e1_ts_mode_names, ts->mode),</span><br><span> ts->fd, get_remote_pid(ts->fd), VTY_NEWLINE);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " SC: Mode %s, FD %d, Peer PID %d%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ get_value_string(e1_ts_mode_names, line->superchan.mode),</span><br><span style="color: hsl(120, 100%, 40%);">+ line->superchan.fd, get_remote_pid(line->superchan.fd), VTY_NEWLINE);</span><br><span> }</span><br><span> </span><br><span> DEFUN(show_line, show_line_cmd, "show line [<0-255>]",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1d/+/19231">change 19231</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1d/+/19231"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-e1d </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id340b1925471f427deb6cda7eb54e80dfc71faec </div>
<div style="display:none"> Gerrit-Change-Number: 19231 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>